Fix method visibility for PhabricatorController subclasses

Summary: Ref T6822.

Test Plan: Visual inspection. These methods are only called from within `PhabricatorController` subclasses.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11241

src/applications/almanac/controller/AlmanacDeviceController.php

@@ -2,7 +2,7 @@
 
 abstract class AlmanacDeviceController extends AlmanacController {
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $list_uri = $this->getApplicationURI('device/');

src/applications/almanac/controller/AlmanacDeviceListController.php

@@ -16,7 +16,7 @@ final class AlmanacDeviceListController
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/almanac/controller/AlmanacNetworkController.php

@@ -2,7 +2,7 @@
 
 abstract class AlmanacNetworkController extends AlmanacController {
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $list_uri = $this->getApplicationURI('network/');

src/applications/almanac/controller/AlmanacNetworkListController.php

@@ -16,7 +16,7 @@ final class AlmanacNetworkListController
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/almanac/controller/AlmanacServiceController.php

@@ -2,7 +2,7 @@
 
 abstract class AlmanacServiceController extends AlmanacController {
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $list_uri = $this->getApplicationURI('service/');

src/applications/almanac/controller/AlmanacServiceListController.php

@@ -16,7 +16,7 @@ final class AlmanacServiceListController
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/audit/controller/PhabricatorAuditController.php

@@ -18,7 +18,7 @@ abstract class PhabricatorAuditController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/auth/controller/config/PhabricatorAuthProviderConfigController.php

@@ -20,7 +20,7 @@ abstract class PhabricatorAuthProviderConfigController
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView($for_app = true)->getMenu();
   }
 

src/applications/calendar/controller/PhabricatorCalendarController.php

@@ -20,11 +20,11 @@ abstract class PhabricatorCalendarController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/config/controller/PhabricatorConfigController.php

@@ -26,7 +26,7 @@ abstract class PhabricatorConfigController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(null, true)->getMenu();
   }
 

src/applications/conpherence/controller/ConpherenceController.php

@@ -4,7 +4,7 @@ abstract class ConpherenceController extends PhabricatorController {
 
   private $conpherences;
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     $nav = new PHUIListView();
 
     $nav->newLink(
@@ -30,7 +30,7 @@ abstract class ConpherenceController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs

src/applications/countdown/controller/PhabricatorCountdownController.php

@@ -21,11 +21,11 @@ abstract class PhabricatorCountdownController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView($for_app = true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/dashboard/controller/PhabricatorDashboardListController.php

@@ -39,7 +39,7 @@ final class PhabricatorDashboardListController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php

@@ -36,7 +36,7 @@ final class PhabricatorDashboardPanelListController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addTextCrumb(pht('Panels'), $this->getApplicationURI().'panel/');

src/applications/dashboard/controller/PhabricatorDashboardViewController.php

@@ -49,7 +49,7 @@ final class PhabricatorDashboardViewController
       ));
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $id = $this->id;
 

src/applications/differential/controller/DifferentialController.php

@@ -2,7 +2,7 @@
 
 abstract class DifferentialController extends PhabricatorController {
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(
@@ -29,7 +29,7 @@ abstract class DifferentialController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

@@ -3,7 +3,7 @@
 abstract class DiffusionRepositoryEditController
   extends DiffusionController {
 
-  public function buildApplicationCrumbs($is_main = false) {
+  protected function buildApplicationCrumbs($is_main = false) {
     $crumbs = parent::buildApplicationCrumbs();
 
     if ($this->diffusionRequest) {

src/applications/diffusion/controller/DiffusionRepositoryListController.php

@@ -37,7 +37,7 @@ final class DiffusionRepositoryListController extends DiffusionController {
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/drydock/controller/DrydockBlueprintController.php

@@ -16,7 +16,7 @@ abstract class DrydockBlueprintController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $crumbs->addTextCrumb(
       pht('Blueprints'),

src/applications/drydock/controller/DrydockBlueprintListController.php

@@ -22,7 +22,7 @@ final class DrydockBlueprintListController extends DrydockBlueprintController {
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $can_create = $this->hasApplicationCapability(
       DrydockCreateBlueprintsCapability::CAPABILITY);
 

src/applications/drydock/controller/DrydockController.php

@@ -4,7 +4,7 @@ abstract class DrydockController extends PhabricatorController {
 
   abstract function buildSideNavView();
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/drydock/controller/DrydockLeaseController.php

@@ -16,7 +16,7 @@ abstract class DrydockLeaseController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $crumbs->addTextCrumb(
       pht('Leases'),

src/applications/drydock/controller/DrydockLogController.php

@@ -16,7 +16,7 @@ abstract class DrydockLogController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $crumbs->addTextCrumb(
       pht('Logs'),

src/applications/drydock/controller/DrydockResourceController.php

@@ -16,7 +16,7 @@ abstract class DrydockResourceController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $crumbs->addTextCrumb(
       pht('Resources'),

src/applications/files/controller/PhabricatorFileListController.php

@@ -21,7 +21,7 @@ final class PhabricatorFileListController extends PhabricatorFileController {
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $crumbs->addAction(
       id(new PHUIListItemView())

src/applications/fund/controller/FundInitiativeListController.php

@@ -40,7 +40,7 @@ final class FundInitiativeListController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/harbormaster/controller/HarbormasterBuildableListController.php

@@ -39,7 +39,7 @@ final class HarbormasterBuildableListController extends HarbormasterController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/harbormaster/controller/HarbormasterController.php

@@ -2,7 +2,7 @@
 
 abstract class HarbormasterController extends PhabricatorController {
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/harbormaster/controller/HarbormasterPlanController.php

@@ -2,7 +2,7 @@
 
 abstract class HarbormasterPlanController extends HarbormasterController {
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addTextCrumb(

src/applications/harbormaster/controller/HarbormasterPlanListController.php

@@ -40,7 +40,7 @@ final class HarbormasterPlanListController extends HarbormasterPlanController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/herald/controller/HeraldController.php

@@ -16,11 +16,11 @@ abstract class HeraldController extends PhabricatorController {
     return $response->setContent($page->render());
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/herald/controller/HeraldTranscriptListController.php

@@ -23,7 +23,7 @@ final class HeraldTranscriptListController extends HeraldController {
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addTextCrumb(

src/applications/legalpad/controller/LegalpadController.php

@@ -22,7 +22,7 @@ abstract class LegalpadController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNav(true)->getMenu();
   }
 

src/applications/legalpad/controller/LegalpadDocumentListController.php

@@ -21,7 +21,7 @@ final class LegalpadDocumentListController extends LegalpadController {
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/legalpad/controller/LegalpadDocumentSignatureListController.php

@@ -64,7 +64,7 @@ final class LegalpadDocumentSignatureListController extends LegalpadController {
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     if ($this->document) {

src/applications/macro/controller/PhabricatorMacroController.php

@@ -20,7 +20,7 @@ abstract class PhabricatorMacroController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView($for_app = true)->getMenu();
   }
 

src/applications/mailinglists/controller/PhabricatorMailingListsController.php

@@ -21,11 +21,11 @@ abstract class PhabricatorMailingListsController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/meta/controller/PhabricatorApplicationsController.php

@@ -17,7 +17,7 @@ abstract class PhabricatorApplicationsController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php

@@ -22,7 +22,7 @@ final class PhabricatorOAuthClientListController
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/owners/controller/PhabricatorOwnersController.php

@@ -58,7 +58,7 @@ abstract class PhabricatorOwnersController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 

src/applications/passphrase/controller/PassphraseController.php

@@ -21,11 +21,11 @@ abstract class PassphraseController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/paste/controller/PhabricatorPasteController.php

@@ -21,11 +21,11 @@ abstract class PhabricatorPasteController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/people/controller/PhabricatorPeopleController.php

@@ -28,11 +28,11 @@ abstract class PhabricatorPeopleController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView()->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $viewer = $this->getRequest()->getUser();

src/applications/phame/controller/PhameController.php

@@ -103,7 +103,7 @@ abstract class PhameController extends PhabricatorController {
     return $stories;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->renderSideNavFilterView()->getMenu();
   }
 

src/applications/pholio/controller/PholioController.php

@@ -21,7 +21,7 @@ abstract class PholioController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(
@@ -33,7 +33,7 @@ abstract class PholioController extends PhabricatorController {
     return $crumbs;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/phortune/controller/PhortuneCartListController.php

@@ -79,7 +79,7 @@ final class PhortuneCartListController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $merchant = $this->merchant;

src/applications/phortune/controller/PhortuneChargeListController.php

@@ -61,7 +61,7 @@ final class PhortuneChargeListController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $account = $this->account;

src/applications/phortune/controller/PhortuneMerchantController.php

@@ -3,7 +3,7 @@
 abstract class PhortuneMerchantController
   extends PhortuneController {
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $crumbs->addTextCrumb(
       pht('Merchants'),

src/applications/phortune/controller/PhortuneMerchantListController.php

@@ -37,7 +37,7 @@ final class PhortuneMerchantListController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/phriction/controller/PhrictionController.php

@@ -22,11 +22,11 @@ abstract class PhrictionController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     if (get_class($this) != 'PhrictionListController') {

src/applications/ponder/controller/PonderController.php

@@ -17,7 +17,7 @@ abstract class PonderController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     $crumbs
       ->addAction(

src/applications/project/controller/PhabricatorProjectListController.php

@@ -22,11 +22,11 @@ final class PhabricatorProjectListController
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $can_create = $this->hasApplicationCapability(

src/applications/releeph/controller/ReleephController.php

@@ -34,7 +34,7 @@ abstract class ReleephController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 

src/applications/releeph/controller/branch/ReleephBranchViewController.php

@@ -103,7 +103,7 @@ final class ReleephBranchViewController extends ReleephBranchController
       ->setViewer($this->getRequest()->getUser());
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $branch = $this->getBranch();

src/applications/releeph/controller/product/ReleephProductListController.php

@@ -21,7 +21,7 @@ final class ReleephProductListController extends ReleephController {
     return $this->delegateToController($controller);
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/releeph/controller/product/ReleephProductViewController.php

@@ -148,7 +148,7 @@ final class ReleephProductViewController extends ReleephProductController
     return $nav;
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $product = $this->getProduct();

src/applications/settings/controller/PhabricatorSettingsMainController.php

@@ -151,7 +151,7 @@ final class PhabricatorSettingsMainController
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     $panels = $this->buildPanels();
     return $this->renderSideNav($panels)->getMenu();
   }

src/applications/slowvote/controller/PhabricatorSlowvoteController.php

@@ -22,11 +22,11 @@ abstract class PhabricatorSlowvoteController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNavView(true)->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
 
     $crumbs->addAction(

src/applications/tokens/controller/PhabricatorTokenController.php

@@ -2,7 +2,6 @@
 
 abstract class PhabricatorTokenController extends PhabricatorController {
 
-
   protected function buildSideNav() {
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
@@ -14,11 +13,11 @@ abstract class PhabricatorTokenController extends PhabricatorController {
     return $nav;
   }
 
-  public function buildApplicationMenu() {
+  protected function buildApplicationMenu() {
     return $this->buildSideNav()->getMenu();
   }
 
-  public function buildApplicationCrumbs() {
+  protected function buildApplicationCrumbs() {
     $crumbs = parent::buildApplicationCrumbs();
     return $crumbs;
   }