From e8401e6d4f9907a8a993785b5bcb07220b1c35e9 Mon Sep 17 00:00:00 2001 From: vrana Date: Mon, 6 Aug 2012 17:17:38 -0700 Subject: [PATCH] Increase width of moved code tooltip Summary: Looks weird with long paths. Test Plan: Displayed diff with moved code. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3173 --- src/__celerity_resource_map__.php | 42 +++++++++---------- .../differential/behavior-populate.js | 4 +- 2 files changed, 24 insertions(+), 22 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index f0413cf3f3..f1fa4a8ac8 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -1138,7 +1138,7 @@ celerity_register_resource_map(array( ), 'javelin-behavior-differential-populate' => array( - 'uri' => '/res/a955bf2c/rsrc/js/application/differential/behavior-populate.js', + 'uri' => '/res/cf4691f5/rsrc/js/application/differential/behavior-populate.js', 'type' => 'js', 'requires' => array( @@ -2885,7 +2885,7 @@ celerity_register_resource_map(array( 'uri' => '/res/pkg/96bc37d6/differential.pkg.css', 'type' => 'css', ), - '5e5a4cb2' => + 'df1fdda8' => array( 'name' => 'differential.pkg.js', 'symbols' => @@ -2909,7 +2909,7 @@ celerity_register_resource_map(array( 16 => 'javelin-behavior-differential-dropdown-menus', 17 => 'javelin-behavior-buoyant', ), - 'uri' => '/res/pkg/5e5a4cb2/differential.pkg.js', + 'uri' => '/res/pkg/df1fdda8/differential.pkg.js', 'type' => 'js', ), 'c8ce2d88' => @@ -3017,7 +3017,7 @@ celerity_register_resource_map(array( 'aphront-typeahead-control-css' => '8b65e80d', 'differential-changeset-view-css' => '96bc37d6', 'differential-core-view-css' => '96bc37d6', - 'differential-inline-comment-editor' => '5e5a4cb2', + 'differential-inline-comment-editor' => 'df1fdda8', 'differential-local-commits-view-css' => '96bc37d6', 'differential-results-table-css' => '96bc37d6', 'differential-revision-add-comment-css' => '96bc37d6', @@ -3030,21 +3030,21 @@ celerity_register_resource_map(array( 'inline-comment-summary-css' => '96bc37d6', 'javelin-behavior' => '6fb20113', 'javelin-behavior-aphront-basic-tokenizer' => '97f65640', - 'javelin-behavior-aphront-drag-and-drop' => '5e5a4cb2', - 'javelin-behavior-aphront-drag-and-drop-textarea' => '5e5a4cb2', + 'javelin-behavior-aphront-drag-and-drop' => 'df1fdda8', + 'javelin-behavior-aphront-drag-and-drop-textarea' => 'df1fdda8', 'javelin-behavior-aphront-form-disable-on-submit' => '971b021e', 'javelin-behavior-audit-preview' => '5e68be89', - 'javelin-behavior-buoyant' => '5e5a4cb2', - 'javelin-behavior-differential-accept-with-errors' => '5e5a4cb2', - 'javelin-behavior-differential-add-reviewers-and-ccs' => '5e5a4cb2', - 'javelin-behavior-differential-comment-jump' => '5e5a4cb2', - 'javelin-behavior-differential-diff-radios' => '5e5a4cb2', - 'javelin-behavior-differential-dropdown-menus' => '5e5a4cb2', - 'javelin-behavior-differential-edit-inline-comments' => '5e5a4cb2', - 'javelin-behavior-differential-feedback-preview' => '5e5a4cb2', - 'javelin-behavior-differential-keyboard-navigation' => '5e5a4cb2', - 'javelin-behavior-differential-populate' => '5e5a4cb2', - 'javelin-behavior-differential-show-more' => '5e5a4cb2', + 'javelin-behavior-buoyant' => 'df1fdda8', + 'javelin-behavior-differential-accept-with-errors' => 'df1fdda8', + 'javelin-behavior-differential-add-reviewers-and-ccs' => 'df1fdda8', + 'javelin-behavior-differential-comment-jump' => 'df1fdda8', + 'javelin-behavior-differential-diff-radios' => 'df1fdda8', + 'javelin-behavior-differential-dropdown-menus' => 'df1fdda8', + 'javelin-behavior-differential-edit-inline-comments' => 'df1fdda8', + 'javelin-behavior-differential-feedback-preview' => 'df1fdda8', + 'javelin-behavior-differential-keyboard-navigation' => 'df1fdda8', + 'javelin-behavior-differential-populate' => 'df1fdda8', + 'javelin-behavior-differential-show-more' => 'df1fdda8', 'javelin-behavior-diffusion-commit-graph' => '5e68be89', 'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89', 'javelin-behavior-maniphest-batch-selector' => '7707de41', @@ -3054,12 +3054,12 @@ celerity_register_resource_map(array( 'javelin-behavior-maniphest-transaction-preview' => '7707de41', 'javelin-behavior-phabricator-autofocus' => '971b021e', 'javelin-behavior-phabricator-keyboard-shortcuts' => '971b021e', - 'javelin-behavior-phabricator-object-selector' => '5e5a4cb2', + 'javelin-behavior-phabricator-object-selector' => 'df1fdda8', 'javelin-behavior-phabricator-oncopy' => '971b021e', 'javelin-behavior-phabricator-tooltips' => '971b021e', 'javelin-behavior-phabricator-watch-anchor' => '971b021e', 'javelin-behavior-refresh-csrf' => '971b021e', - 'javelin-behavior-repository-crossreference' => '5e5a4cb2', + 'javelin-behavior-repository-crossreference' => 'df1fdda8', 'javelin-behavior-workflow' => '971b021e', 'javelin-dom' => '6fb20113', 'javelin-event' => '6fb20113', @@ -3085,7 +3085,7 @@ celerity_register_resource_map(array( 'phabricator-core-buttons-css' => '8b65e80d', 'phabricator-core-css' => '8b65e80d', 'phabricator-directory-css' => '8b65e80d', - 'phabricator-drag-and-drop-file-upload' => '5e5a4cb2', + 'phabricator-drag-and-drop-file-upload' => 'df1fdda8', 'phabricator-dropdown-menu' => '971b021e', 'phabricator-flag-css' => '8b65e80d', 'phabricator-jump-nav' => '8b65e80d', @@ -3097,7 +3097,7 @@ celerity_register_resource_map(array( 'phabricator-prefab' => '971b021e', 'phabricator-project-tag-css' => '7839ae2d', 'phabricator-remarkup-css' => '8b65e80d', - 'phabricator-shaped-request' => '5e5a4cb2', + 'phabricator-shaped-request' => 'df1fdda8', 'phabricator-standard-page-view' => '8b65e80d', 'phabricator-tooltip' => '971b021e', 'phabricator-transaction-view-css' => '8b65e80d', diff --git a/webroot/rsrc/js/application/differential/behavior-populate.js b/webroot/rsrc/js/application/differential/behavior-populate.js index 2c718dfe40..d5ffe031ae 100644 --- a/webroot/rsrc/js/application/differential/behavior-populate.js +++ b/webroot/rsrc/js/application/differential/behavior-populate.js @@ -80,6 +80,7 @@ JX.behavior('differential-populate', function(config) { var msg; var align = 'E'; var sibling = 'previousSibling'; + var width = 120; if (t.className.match(/cov-C/)) { msg = 'Covered'; highlight_class = 'source-cov-C'; @@ -94,13 +95,14 @@ JX.behavior('differential-populate', function(config) { if (match) { align = 'N'; // TODO: 'W' sibling = 'nextSibling'; + width = 500; msg = JX.Stratcom.getData(t).msg; highlight_class = match[0]; } } if (msg) { - JX.Tooltip.show(t, 120, align, msg); + JX.Tooltip.show(t, width, align, msg); } if (highlight_class) {