From e8c57581924358ee9c9677611a0033a715df8825 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 31 Jan 2017 13:28:50 -0800
Subject: [PATCH] Improve page titles for menu items that render in-context
 content

Summary: Ref T12174. Dashboards and "Home" currently use the page title "Configure Menu". Give them more appropriate titles instead.

Test Plan: Viewed dashboards, Home. Saw relevant page titles.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17281
---
 .../search/engine/PhabricatorProfileMenuEngine.php         | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/applications/search/engine/PhabricatorProfileMenuEngine.php b/src/applications/search/engine/PhabricatorProfileMenuEngine.php
index 319d1fa774..c480e6a481 100644
--- a/src/applications/search/engine/PhabricatorProfileMenuEngine.php
+++ b/src/applications/search/engine/PhabricatorProfileMenuEngine.php
@@ -214,6 +214,9 @@ abstract class PhabricatorProfileMenuEngine extends Phobject {
           }
         }
       }
+      $page_title = pht('Configure Menu');
+    } else {
+      $page_title = $selected_item->getDisplayName();
     }
 
     switch ($item_action) {
@@ -293,10 +296,8 @@ abstract class PhabricatorProfileMenuEngine extends Phobject {
 
     $crumbs->setBorder(true);
 
-    // TODO: This title is not correct when viewing items.
-
     $page = $controller->newPage()
-      ->setTitle(pht('Configure Menu'))
+      ->setTitle($page_title)
       ->setCrumbs($crumbs)
       ->appendChild($content);