From e8c6c81b6ea4ba7d0e2b8eeb99a4b02d90b1d25f Mon Sep 17 00:00:00 2001 From: Kyle Jao Date: Sat, 26 Apr 2014 12:51:47 -0700 Subject: [PATCH] Fix for showing an unregistered author name in the tooltip of diffusion revision link Summary: When showing contents of a file with the blame mode enabled, tooltips pops out when the mouse hovers over previous commit linkes on left side. The last part of the tooltips is the author's name. If an author is unregistered, the name becomes name. {F147724} This doesn't happen if the author is registered. Test Plan: Check tooltips after making the change. {F147725} Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8869 --- .../diffusion/controller/DiffusionBrowseFileController.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php index 39c9574403..91c2577e16 100644 --- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php +++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php @@ -538,11 +538,7 @@ final class DiffusionBrowseFileController extends DiffusionBrowseController { if ($author_phid && $handles[$author_phid]) { $author_link = $handles[$author_phid]->renderLink(); } else { - $author_link = phutil_tag( - 'span', - array( - ), - $blame['author']); + $author_link = $blame['author']; } $display_line['author'] = $author_link;