From e8dca5a4f9be51398091c82fddce5165b6853a74 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 29 Apr 2016 16:52:27 -0700
Subject: [PATCH] Alternate fix for Firefox triple click selection

Summary:
Fixes T10905. This reverts D15823, which didn't work well for tasks with very long titles (the title would break as a block element).

This is slightly more magic but works with long titles.

Test Plan: Did everything from D15823, but also with long titles. Triple-click, wrapping, and mobile/device worked in Safari, Firefox and Chrome.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10905

Differential Revision: https://secure.phabricator.com/D15824
---
 resources/celerity/map.php                 | 6 +++---
 src/view/phui/PHUIHeaderView.php           | 9 ---------
 webroot/rsrc/css/phui/phui-header-view.css | 6 +++---
 3 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 0ec094c82b..cd0efd5db5 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'ede6bf7a',
+    'core.pkg.css' => 'b729f9f5',
     'core.pkg.js' => '6972d365',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '7ba78475',
@@ -136,7 +136,7 @@ return array(
     'rsrc/css/phui/phui-form-view.css' => '6a51768e',
     'rsrc/css/phui/phui-form.css' => 'aac1d51d',
     'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
-    'rsrc/css/phui/phui-header-view.css' => '9961e480',
+    'rsrc/css/phui/phui-header-view.css' => '4c7dd8f5',
     'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
     'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
     'rsrc/css/phui/phui-icon.css' => '3f33ab57',
@@ -829,7 +829,7 @@ return array(
     'phui-form-css' => 'aac1d51d',
     'phui-form-view-css' => '6a51768e',
     'phui-head-thing-view-css' => 'fd311e5f',
-    'phui-header-view-css' => '9961e480',
+    'phui-header-view-css' => '4c7dd8f5',
     'phui-hovercard' => '1bd28176',
     'phui-hovercard-view-css' => 'de1a2119',
     'phui-icon-set-selector-css' => '1ab67aad',
diff --git a/src/view/phui/PHUIHeaderView.php b/src/view/phui/PHUIHeaderView.php
index 85f55b3ef7..8111944c4d 100644
--- a/src/view/phui/PHUIHeaderView.php
+++ b/src/view/phui/PHUIHeaderView.php
@@ -316,15 +316,6 @@ final class PHUIHeaderView extends AphrontTagView {
         $header_content);
     }
 
-    // This wrapper element allows titles to be triple-clicked to select them
-    // in Firefox. See T10905 for discussion.
-    $header_content = phutil_tag(
-      'span',
-      array(
-        'class' => 'phui-header-content',
-      ),
-      $header_content);
-
     $left[] = phutil_tag(
       'span',
       array(
diff --git a/webroot/rsrc/css/phui/phui-header-view.css b/webroot/rsrc/css/phui/phui-header-view.css
index 6cbf3b891a..2336ec3696 100644
--- a/webroot/rsrc/css/phui/phui-header-view.css
+++ b/webroot/rsrc/css/phui/phui-header-view.css
@@ -78,10 +78,10 @@ body .phui-header-shell.phui-bleed-header
 .phui-header-header .phui-header-icon {
   margin-right: 8px;
   color: {$lightbluetext};
-}
 
-.phui-header-content {
-  display: inline-block;
+  /* This allows the header text to be triple-clicked to select it in Firefox,
+     see T10905 for discussion. */
+  display: inline;
 }
 
 .phui-object-box .phui-header-tall .phui-header-header,