From e8e185ceb30e5c0dc11b65e8f1b571ed28f3c2b2 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 9 Feb 2011 20:12:20 -0800 Subject: [PATCH] Make Maniphest emails align title numbers better and fix a transaction aggregation bug. Summary: Transactions always aggregated even when separated by large time differences becuase of some clown typoing; fix that. Also make the subject lines for tasks align better in the inbox. Test Plan: I'm feeling lucky. Differential Revision: 29 Reviewed By: tomo Reviewers: tomo --- .../maniphest/editor/transaction/ManiphestTransactionEditor.php | 2 +- .../maniphest/storage/transaction/ManiphestTransaction.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php index a6a0c8abbd..182749bef4 100644 --- a/src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php +++ b/src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php @@ -154,7 +154,7 @@ class ManiphestTransactionEditor { id(new PhabricatorMetaMTAMail()) ->setSubject( - '[Maniphest] '.$action.': T'.$task->getID().' '.$task->getTitle()) + '[Maniphest] T'.$task->getID().' '.$action.': '.$task->getTitle()) ->setFrom($transaction->getAuthorPHID()) ->addTos($email_to) ->addCCs($email_cc) diff --git a/src/applications/maniphest/storage/transaction/ManiphestTransaction.php b/src/applications/maniphest/storage/transaction/ManiphestTransaction.php index a7e4b931dc..07d9e8d681 100644 --- a/src/applications/maniphest/storage/transaction/ManiphestTransaction.php +++ b/src/applications/maniphest/storage/transaction/ManiphestTransaction.php @@ -66,7 +66,7 @@ class ManiphestTransaction extends ManiphestDAO { return false; } $ttime = $target->getDateCreated(); - $stime = $target->getDateCreated(); + $stime = $this->getDateCreated(); if (abs($stime - $ttime) > 60) { return false; }