From e965a59bca56ddee3efdb0b07ce5d5f0266c9b52 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Mon, 4 Apr 2016 20:34:23 -0700
Subject: [PATCH] Update Batch Edit and Report pages

Summary: Moves these Maniphest pages over to modern UI, components

Test Plan: Batch Edit Tasks, View some reports.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15614
---
 resources/celerity/map.php                    |  6 ++---
 .../ManiphestBatchEditController.php          | 23 +++++++++++++------
 .../controller/ManiphestReportController.php  | 20 ++++++++--------
 webroot/rsrc/css/phui/phui-box.css            |  2 +-
 4 files changed, 30 insertions(+), 21 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 930a2e5b41..64455ce942 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'a3016dac',
+    'core.pkg.css' => '97b752c8',
     'core.pkg.js' => 'e5484f37',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '7ba78475',
@@ -123,7 +123,7 @@ return array(
     'rsrc/css/phui/phui-action-panel.css' => '91c7b835',
     'rsrc/css/phui/phui-badge.css' => 'f25c3476',
     'rsrc/css/phui/phui-big-info-view.css' => 'bd903741',
-    'rsrc/css/phui/phui-box.css' => 'b2d49bae',
+    'rsrc/css/phui/phui-box.css' => '9c9159a7',
     'rsrc/css/phui/phui-button.css' => 'a64a8de6',
     'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
     'rsrc/css/phui/phui-crumbs-view.css' => '79d536e5',
@@ -805,7 +805,7 @@ return array(
     'phui-action-panel-css' => '91c7b835',
     'phui-badge-view-css' => 'f25c3476',
     'phui-big-info-view-css' => 'bd903741',
-    'phui-box-css' => 'b2d49bae',
+    'phui-box-css' => '9c9159a7',
     'phui-button-css' => 'a64a8de6',
     'phui-calendar-css' => 'ccabe893',
     'phui-calendar-day-css' => 'd1cf6f93',
diff --git a/src/applications/maniphest/controller/ManiphestBatchEditController.php b/src/applications/maniphest/controller/ManiphestBatchEditController.php
index d245817f20..90fcda28ec 100644
--- a/src/applications/maniphest/controller/ManiphestBatchEditController.php
+++ b/src/applications/maniphest/controller/ManiphestBatchEditController.php
@@ -194,24 +194,33 @@ final class ManiphestBatchEditController extends ManiphestController {
 
     $crumbs = $this->buildApplicationCrumbs();
     $crumbs->addTextCrumb($title);
+    $crumbs->setBorder(true);
+
+    $header = id(new PHUIHeaderView())
+      ->setHeader(pht('Batch Editor'))
+      ->setHeaderIcon('fa-pencil-square-o');
 
     $task_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Selected Tasks'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setObjectList($list);
 
     $form_box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('Batch Editor'))
+      ->setHeaderText(pht('Actions'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
       ->setForm($form);
 
-    return $this->buildApplicationPage(
-      array(
-        $crumbs,
+    $view = id(new PHUITwoColumnView())
+      ->setHeader($header)
+      ->setFooter(array(
         $task_box,
         $form_box,
-      ),
-      array(
-        'title' => $title,
       ));
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild($view);
   }
 
 }
diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
index c7f0cf2186..f16281691b 100644
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -45,17 +45,17 @@ final class ManiphestReportController extends ManiphestController {
         return new Aphront404Response();
     }
 
-    $nav->appendChild($core);
-    $nav->setCrumbs(
-      $this->buildApplicationCrumbs()
-        ->addTextCrumb(pht('Reports')));
+    $crumbs = $this->buildApplicationCrumbs()
+      ->addTextCrumb(pht('Reports'));
+
+    $nav->appendChild($core);
+    $title = pht('Maniphest Reports');
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->setNavigation($nav);
 
-    return $this->buildApplicationPage(
-      $nav,
-      array(
-        'title' => pht('Maniphest Reports'),
-        'device' => false,
-      ));
   }
 
   public function renderBurn() {
diff --git a/webroot/rsrc/css/phui/phui-box.css b/webroot/rsrc/css/phui/phui-box.css
index 35f5067fec..30328d0d38 100644
--- a/webroot/rsrc/css/phui/phui-box.css
+++ b/webroot/rsrc/css/phui/phui-box.css
@@ -97,7 +97,7 @@
   color: {$bluetext};
 }
 
-.phui-box-blue-property .phui-object-item-list-view.phui-object-list-flush {
+.phui-box-blue-property .phui-object-item-list-view {
   padding: 2px 8px;
 }