revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Don't send email to bots subscribed to diffs

Browse source 
Summary:
Occasionally a bot will get subscribed to a differential revision; when
this happens we shouldn't send them an email, because otherwise the
author of the diff will get a bounce email if the bot has an invalid
emal address.

Test Plan:
re-sent a message that had a bot on the cc list, saw that it was no longer
included when it got sent.

Reviewers: epriestley, jungejason, vrana

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2479
This commit is contained in:
Nick Harper 2012-05-16 10:26:03 -07:00
parent 6865f024c8
commit e9c3894861
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/phid/handle/data/PhabricatorObjectHandleData.php
View file

@ -171,7 +171,8 @@ final class PhabricatorObjectHandleData {
$user->getUsername().' ('.$user->getRealName().')'); $user->getUsername().' ('.$user->getRealName().')');
$handle->setAlternateID($user->getID()); $handle->setAlternateID($user->getID());
$handle->setComplete(true); $handle->setComplete(true);
$handle->setDisabled($user->getIsDisabled()); $handle->setDisabled($user->getIsDisabled() ||
$user->getIsSystemAgent());
$img_uri = idx($images, $user->getProfileImagePHID()); $img_uri = idx($images, $user->getProfileImagePHID());
if ($img_uri) { if ($img_uri) {