From ea66aead59a5cdcfa116a0785cda4aefe9e280c2 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 24 Apr 2014 10:35:28 -0700
Subject: [PATCH] Fix an issue with multiple "open" statuses and the "View All"
 button on Projects

Summary: See IRC. We construct this a little bit wrong if there are multiple "open" statuses. Use a more modern construction.

Test Plan: Hit `?statuses=wontfix,invalid`, etc. Clicked "view all" from projects.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8854
---
 .../maniphest/query/ManiphestTaskSearchEngine.php      | 10 ++++++++--
 .../controller/PhabricatorProjectProfileController.php |  4 ++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
index ce51d55820..9e88e4c87b 100644
--- a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
+++ b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
@@ -24,8 +24,14 @@ final class ManiphestTaskSearchEngine
       'subscriberPHIDs',
       $this->readPHIDsFromRequest($request, 'subscribers'));
 
-    $saved->setParameter('statuses', $request->getArr('statuses'));
-    $saved->setParameter('priorities', $request->getArr('priorities'));
+    $saved->setParameter(
+      'statuses',
+      $this->readListFromRequest($request, 'statuses'));
+
+    $saved->setParameter(
+      'priorities',
+      $this->readListFromRequest($request, 'priorities'));
+
     $saved->setParameter('group', $request->getStr('group'));
     $saved->setParameter('order', $request->getStr('order'));
 
diff --git a/src/applications/project/controller/PhabricatorProjectProfileController.php b/src/applications/project/controller/PhabricatorProjectProfileController.php
index dc4f5528b4..7a09ca0d77 100644
--- a/src/applications/project/controller/PhabricatorProjectProfileController.php
+++ b/src/applications/project/controller/PhabricatorProjectProfileController.php
@@ -147,8 +147,8 @@ final class PhabricatorProjectProfileController
     $task_list->setHandles($handles);
 
     $phid = $project->getPHID();
-    $view_uri = sprintf(
-      '/maniphest/?statuses[]=%s&allProjects[]=%s#R',
+    $view_uri = urisprintf(
+      '/maniphest/?statuses=%s&allProjects[]=%s#R',
       implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
       $phid);
     $create_uri = '/maniphest/task/create/?projects='.$phid;