From ea78f920ddfb29a9725ee9e8dbc8fd6e80287d23 Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Wed, 1 May 2013 14:42:58 -0700 Subject: [PATCH] Conpherence - workflow the Message link on people profiles Summary: Fixes T2416. I was tired of looking at this task in the list, interns be damned. :D Test Plan: it is now a workflow when you click it Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2416 Differential Revision: https://secure.phabricator.com/D5811 --- .../controller/ConpherenceNewController.php | 21 +++---------------- .../ConpherencePeopleMenuEventListener.php | 1 + 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/src/applications/conpherence/controller/ConpherenceNewController.php b/src/applications/conpherence/controller/ConpherenceNewController.php index d48f2bb65a..add2b7b18f 100644 --- a/src/applications/conpherence/controller/ConpherenceNewController.php +++ b/src/applications/conpherence/controller/ConpherenceNewController.php @@ -86,24 +86,9 @@ final class ConpherenceNewController extends ConpherenceController { $conpherence->saveTransaction(); - if ($request->isAjax()) { - $dialog = id(new AphrontDialogView()) - ->setUser($user) - ->setTitle('Success') - ->addCancelButton('#', 'Okay') - ->appendChild( - phutil_tag( - 'p', - array(), - pht('Message sent successfully.'))); - $response = id(new AphrontDialogResponse()) - ->setDialog($dialog); - } else { - $uri = $this->getApplicationURI($conpherence->getID()); - $response = id(new AphrontRedirectResponse()) - ->setURI($uri); - } - return $response; + $uri = $this->getApplicationURI($conpherence->getID()); + return id(new AphrontRedirectResponse()) + ->setURI($uri); } } diff --git a/src/applications/conpherence/events/ConpherencePeopleMenuEventListener.php b/src/applications/conpherence/events/ConpherencePeopleMenuEventListener.php index baf6002e38..4b1c245b3d 100644 --- a/src/applications/conpherence/events/ConpherencePeopleMenuEventListener.php +++ b/src/applications/conpherence/events/ConpherencePeopleMenuEventListener.php @@ -28,6 +28,7 @@ final class ConpherencePeopleMenuEventListener extends PhutilEventListener { ->setIsExternal(true) ->setName($name) ->setHref($conpherence_uri) + ->setWorkflow(true) ->setKey($name)); $event->setValue('menu', $menu);