From ea8be11addd7a33de3b9b155220324b24d300df1 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sun, 30 Dec 2018 10:54:06 -0800
Subject: [PATCH] Fix a qsprintf() issue in mail queries

Summary: Ref T920. Bumped into this while looking at SMS support.

Test Plan: Loaded `/mail/`, no more `qsprintf()` warning.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T920

Differential Revision: https://secure.phabricator.com/D19936
---
 .../metamta/query/PhabricatorMetaMTAMailQuery.php           | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php b/src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php
index e0dadb5f13..a1fad69c0b 100644
--- a/src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php
+++ b/src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php
@@ -99,8 +99,8 @@ final class PhabricatorMetaMTAMailQuery
     return $where;
   }
 
-  protected function buildJoinClause(AphrontDatabaseConnection $conn) {
-    $joins = array();
+  protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) {
+    $joins = parent::buildJoinClauseParts($conn);
 
     if ($this->actorPHIDs === null && $this->recipientPHIDs === null) {
       $joins[] = qsprintf(
@@ -119,7 +119,7 @@ final class PhabricatorMetaMTAMailQuery
         PhabricatorMetaMTAMailHasRecipientEdgeType::EDGECONST);
     }
 
-    return implode(' ', $joins);
+    return $joins;
   }
 
   protected function getPrimaryTableAlias() {