Make Differential use viewer's token instead of viewer() token again

Summary: Ref T4100. This restores the simpler behavior. See discussion in T4100#107445

Test Plan: Used Differential search, saw my token.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12447

resources/celerity/map.php

@@ -7,8 +7,8 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '5efa6280',
-    'core.pkg.js' => '6a4f677f',
+    'core.pkg.css' => 'f46ba5fa',
+    'core.pkg.js' => 'b00140fe',
     'darkconsole.pkg.js' => '8ab24e01',
     'differential.pkg.css' => '3500921f',
     'differential.pkg.js' => 'c0506961',
@@ -27,9 +27,10 @@ return array(
     'rsrc/css/aphront/panel-view.css' => '8427b78d',
     'rsrc/css/aphront/phabricator-nav-view.css' => '7aeaf435',
     'rsrc/css/aphront/table-view.css' => '59e2c0f8',
-    'rsrc/css/aphront/tokenizer.css' => '82ce2142',
+    'rsrc/css/aphront/tokenizer.css' => '6fd738ea',
     'rsrc/css/aphront/tooltip.css' => '7672b60f',
     'rsrc/css/aphront/two-column.css' => '16ab3ad2',
+    'rsrc/css/aphront/typeahead-browse.css' => '343ab59f',
     'rsrc/css/aphront/typeahead.css' => '0e403212',
     'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
     'rsrc/css/application/auth/auth.css' => '1e655982',
@@ -221,9 +222,9 @@ return array(
     'rsrc/externals/javelin/lib/__tests__/URI.js' => '1e45fda9',
     'rsrc/externals/javelin/lib/__tests__/behavior.js' => '1ea62783',
     'rsrc/externals/javelin/lib/behavior.js' => '61cbc29a',
-    'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => '7644823e',
+    'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => 'dc708b7e',
     'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => '70baed2f',
-    'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => '6f7a9da8',
+    'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => 'e6e25838',
     'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '503e17fd',
     'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '8b3fd187',
     'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js' => '54f314a0',
@@ -389,10 +390,10 @@ return array(
     'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => 'e5822781',
     'rsrc/js/application/files/behavior-icon-composer.js' => '8ef9ab58',
     'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
-    'rsrc/js/application/herald/HeraldRuleEditor.js' => '6e2de6f2',
+    'rsrc/js/application/herald/HeraldRuleEditor.js' => '9229e764',
     'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
     'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
-    'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f24f3253',
+    'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f5d1233b',
     'rsrc/js/application/maniphest/behavior-batch-selector.js' => '7b98d7c5',
     'rsrc/js/application/maniphest/behavior-line-chart.js' => '88f0c5b3',
     'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2',
@@ -410,7 +411,7 @@ return array(
     'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
     'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
     'rsrc/js/application/policy/behavior-policy-control.js' => 'f3fef818',
-    'rsrc/js/application/policy/behavior-policy-rule-editor.js' => 'fe9a552f',
+    'rsrc/js/application/policy/behavior-policy-rule-editor.js' => '5e9f347c',
     'rsrc/js/application/ponder/behavior-votebox.js' => '4e9b766b',
     'rsrc/js/application/projects/behavior-boards-dropdown.js' => '0ec56e1d',
     'rsrc/js/application/projects/behavior-project-boards.js' => '87cb6b51',
@@ -425,6 +426,8 @@ return array(
     'rsrc/js/application/transactions/behavior-show-older-transactions.js' => 'dbbf48b6',
     'rsrc/js/application/transactions/behavior-transaction-comment-form.js' => '9f7309fb',
     'rsrc/js/application/transactions/behavior-transaction-list.js' => '13c739ea',
+    'rsrc/js/application/typeahead/behavior-typeahead-browse.js' => '635de1ec',
+    'rsrc/js/application/typeahead/behavior-typeahead-search.js' => '93d0c9e3',
     'rsrc/js/application/uiexample/JavelinViewExample.js' => 'd4a14807',
     'rsrc/js/application/uiexample/ReactorButtonExample.js' => 'd19198c8',
     'rsrc/js/application/uiexample/ReactorCheckboxExample.js' => '519705ea',
@@ -447,7 +450,7 @@ return array(
     'rsrc/js/core/KeyboardShortcutManager.js' => 'c1700f6f',
     'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
     'rsrc/js/core/Notification.js' => '0c6946e7',
-    'rsrc/js/core/Prefab.js' => '72da38cc',
+    'rsrc/js/core/Prefab.js' => '4c292cc5',
     'rsrc/js/core/ShapedRequest.js' => '7cbe244b',
     'rsrc/js/core/TextAreaUtils.js' => '5c93c52c',
     'rsrc/js/core/Title.js' => 'df5e11d2',
@@ -507,7 +510,7 @@ return array(
     'aphront-pager-view-css' => '2e3539af',
     'aphront-panel-view-css' => '8427b78d',
     'aphront-table-view-css' => '59e2c0f8',
-    'aphront-tokenizer-control-css' => '82ce2142',
+    'aphront-tokenizer-control-css' => '6fd738ea',
     'aphront-tooltip-css' => '7672b60f',
     'aphront-two-column-view-css' => '16ab3ad2',
     'aphront-typeahead-control-css' => '0e403212',
@@ -541,7 +544,7 @@ return array(
     'global-drag-and-drop-css' => '697324ad',
     'harbormaster-css' => '49d64eb4',
     'herald-css' => '826075fa',
-    'herald-rule-editor' => '6e2de6f2',
+    'herald-rule-editor' => '9229e764',
     'herald-test-css' => '778b008e',
     'homepage-panel-css' => 'e34bf140',
     'inline-comment-summary-css' => 'eb5f8e8c',
@@ -599,7 +602,7 @@ return array(
     'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
     'javelin-behavior-line-chart' => '88f0c5b3',
     'javelin-behavior-load-blame' => '42126667',
-    'javelin-behavior-maniphest-batch-editor' => 'f24f3253',
+    'javelin-behavior-maniphest-batch-editor' => 'f5d1233b',
     'javelin-behavior-maniphest-batch-selector' => '7b98d7c5',
     'javelin-behavior-maniphest-list-editor' => 'a9f88de2',
     'javelin-behavior-maniphest-subpriority-editor' => '84845b5b',
@@ -637,7 +640,7 @@ return array(
     'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
     'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
     'javelin-behavior-policy-control' => 'f3fef818',
-    'javelin-behavior-policy-rule-editor' => 'fe9a552f',
+    'javelin-behavior-policy-rule-editor' => '5e9f347c',
     'javelin-behavior-ponder-votebox' => '4e9b766b',
     'javelin-behavior-project-boards' => '87cb6b51',
     'javelin-behavior-project-create' => '065227cc',
@@ -657,6 +660,8 @@ return array(
     'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
     'javelin-behavior-test-payment-form' => 'fc91ab6c',
     'javelin-behavior-toggle-class' => 'e566f52c',
+    'javelin-behavior-typeahead-browse' => '635de1ec',
+    'javelin-behavior-typeahead-search' => '93d0c9e3',
     'javelin-behavior-view-placeholder' => '47830651',
     'javelin-behavior-workflow' => '0a3f3021',
     'javelin-color' => '7e41274a',
@@ -684,10 +689,10 @@ return array(
     'javelin-scrollbar' => 'eaa5b321',
     'javelin-sound' => '949c0fe5',
     'javelin-stratcom' => '6c53634d',
-    'javelin-tokenizer' => '7644823e',
+    'javelin-tokenizer' => 'dc708b7e',
     'javelin-typeahead' => '70baed2f',
     'javelin-typeahead-composite-source' => '503e17fd',
-    'javelin-typeahead-normalizer' => '6f7a9da8',
+    'javelin-typeahead-normalizer' => 'e6e25838',
     'javelin-typeahead-ondemand-source' => '8b3fd187',
     'javelin-typeahead-preloaded-source' => '54f314a0',
     'javelin-typeahead-source' => '2818f5ce',
@@ -739,7 +744,7 @@ return array(
     'phabricator-notification-menu-css' => '3c9d8aa1',
     'phabricator-object-selector-css' => '029a133d',
     'phabricator-phtize' => 'd254d646',
-    'phabricator-prefab' => '72da38cc',
+    'phabricator-prefab' => '4c292cc5',
     'phabricator-profile-css' => '1a20dcbf',
     'phabricator-remarkup-css' => 'e10512ff',
     'phabricator-search-results-css' => '15c71110',
@@ -833,6 +838,7 @@ return array(
     'sprite-tokens-css' => '1706b943',
     'syntax-highlighting-css' => '56c1ba38',
     'tokens-css' => '3d0f239e',
+    'typeahead-browse-css' => '343ab59f',
     'unhandled-exception-css' => '37d4f9a2',
   ),
   'requires' => array(
@@ -1146,6 +1152,18 @@ return array(
     '4a2430d7' => array(
       'phui-fontkit-css',
     ),
+    '4c292cc5' => array(
+      'javelin-install',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-typeahead',
+      'javelin-tokenizer',
+      'javelin-typeahead-preloaded-source',
+      'javelin-typeahead-ondemand-source',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-util',
+    ),
     '4d94d9c3' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1238,6 +1256,14 @@ return array(
       'javelin-dom',
       'javelin-vector',
     ),
+    '5e9f347c' => array(
+      'javelin-behavior',
+      'multirow-row-manager',
+      'javelin-dom',
+      'javelin-util',
+      'phabricator-prefab',
+      'javelin-json',
+    ),
     '5fefb143' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1267,6 +1293,12 @@ return array(
       'javelin-install',
       'javelin-util',
     ),
+    '635de1ec' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-workflow',
+      'javelin-dom',
+    ),
     '6882e80a' => array(
       'javelin-dom',
     ),
@@ -1296,15 +1328,6 @@ return array(
       'phabricator-drag-and-drop-file-upload',
       'phabricator-textareautils',
     ),
-    '6e2de6f2' => array(
-      'multirow-row-manager',
-      'javelin-install',
-      'javelin-util',
-      'javelin-dom',
-      'javelin-stratcom',
-      'javelin-json',
-      'phabricator-prefab',
-    ),
     '6e8cefa4' => array(
       'javelin-install',
       'javelin-dom',
@@ -1322,8 +1345,8 @@ return array(
       'javelin-vector',
       'javelin-stratcom',
     ),
-    '6f7a9da8' => array(
-      'javelin-install',
+    '6fd738ea' => array(
+      'aphront-typeahead-control-css',
     ),
     '70baed2f' => array(
       'javelin-install',
@@ -1341,18 +1364,6 @@ return array(
       'javelin-stratcom',
       'phabricator-prefab',
     ),
-    '72da38cc' => array(
-      'javelin-install',
-      'javelin-util',
-      'javelin-dom',
-      'javelin-typeahead',
-      'javelin-tokenizer',
-      'javelin-typeahead-preloaded-source',
-      'javelin-typeahead-ondemand-source',
-      'javelin-dom',
-      'javelin-stratcom',
-      'javelin-util',
-    ),
     '7319e029' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1362,12 +1373,6 @@ return array(
       'javelin-vector',
       'javelin-dom',
     ),
-    '7644823e' => array(
-      'javelin-dom',
-      'javelin-util',
-      'javelin-stratcom',
-      'javelin-install',
-    ),
     '76b9fc3e' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1452,9 +1457,6 @@ return array(
       'javelin-workflow',
       'phabricator-draggable-list',
     ),
-    '82ce2142' => array(
-      'aphront-typeahead-control-css',
-    ),
     '834a1173' => array(
       'javelin-behavior',
       'javelin-scrollbar',
@@ -1546,6 +1548,15 @@ return array(
       'javelin-dom',
       'javelin-stratcom',
     ),
+    '9229e764' => array(
+      'multirow-row-manager',
+      'javelin-install',
+      'javelin-util',
+      'javelin-dom',
+      'javelin-stratcom',
+      'javelin-json',
+      'phabricator-prefab',
+    ),
     93568464 => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1559,6 +1570,12 @@ return array(
       'phuix-action-view',
       'conpherence-thread-manager',
     ),
+    '93d0c9e3' => array(
+      'javelin-behavior',
+      'javelin-stratcom',
+      'javelin-workflow',
+      'javelin-dom',
+    ),
     '9414ff18' => array(
       'javelin-behavior',
       'javelin-resource',
@@ -1817,6 +1834,12 @@ return array(
       'javelin-dom',
       'phabricator-busy',
     ),
+    'dc708b7e' => array(
+      'javelin-dom',
+      'javelin-util',
+      'javelin-stratcom',
+      'javelin-install',
+    ),
     'de2e896f' => array(
       'javelin-behavior',
       'javelin-dom',
@@ -1896,6 +1919,9 @@ return array(
       'javelin-behavior-device',
       'phabricator-keyboard-shortcut',
     ),
+    'e6e25838' => array(
+      'javelin-install',
+    ),
     'e723c323' => array(
       'javelin-behavior',
       'javelin-stratcom',
@@ -1927,14 +1953,6 @@ return array(
       'javelin-install',
       'javelin-util',
     ),
-    'f24f3253' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-util',
-      'phabricator-prefab',
-      'multirow-row-manager',
-      'javelin-json',
-    ),
     'f36e01af' => array(
       'javelin-behavior',
       'javelin-behavior-device',
@@ -1951,6 +1969,14 @@ return array(
       'phuix-action-view',
       'javelin-workflow',
     ),
+    'f5d1233b' => array(
+      'javelin-behavior',
+      'javelin-dom',
+      'javelin-util',
+      'phabricator-prefab',
+      'multirow-row-manager',
+      'javelin-json',
+    ),
     'f6555212' => array(
       'javelin-install',
       'javelin-reactornode',
@@ -2015,14 +2041,6 @@ return array(
       'javelin-view-visitor',
       'javelin-util',
     ),
-    'fe9a552f' => array(
-      'javelin-behavior',
-      'multirow-row-manager',
-      'javelin-dom',
-      'javelin-util',
-      'phabricator-prefab',
-      'javelin-json',
-    ),
   ),
   'packages' => array(
     'core.pkg.css' => array(

src/applications/differential/query/DifferentialRevisionSearchEngine.php

@@ -212,7 +212,7 @@ final class DifferentialRevisionSearchEngine
     switch ($query_key) {
       case 'active':
         return $query
-          ->setParameter('responsiblePHIDs', array('viewer()'))
+          ->setParameter('responsiblePHIDs', array($viewer->getPHID()))
           ->setParameter('status', DifferentialRevisionQuery::STATUS_OPEN);
       case 'authored':
         return $query