revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-11 11:58:33 +02:00
Code Issues Releases Wiki Activity

Minor quality of life updates to Phurl

Browse source 
Summary: Default to "All" (maybe "Active" in the future). Adds more info to results.

Test Plan: visit /phurl/, see additional information about URL

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15713
This commit is contained in:
Chad Little 2016-04-14 18:25:22 +00:00 • committed by chad
parent 07fc8f17cc
commit eae82c51f5
2 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
View file

@ -114,7 +114,7 @@ final class PhabricatorPhurlURLViewController
$curtain $curtain
->addAction( ->addAction(
id(new PhabricatorActionView()) id(new PhabricatorActionView())
->setName(pht('Edit')) ->setName(pht('Edit Phurl'))
->setIcon('fa-pencil') ->setIcon('fa-pencil')
->setHref($this->getApplicationURI("url/edit/{$id}/")) ->setHref($this->getApplicationURI("url/edit/{$id}/"))
->setDisabled(!$can_edit) ->setDisabled(!$can_edit)

10
src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php
View file

@ -44,8 +44,8 @@ final class PhabricatorPhurlURLSearchEngine
protected function getBuiltinQueryNames() { protected function getBuiltinQueryNames() {
$names = array( $names = array(
'authored' => pht('Authored'),
'all' => pht('All URLs'), 'all' => pht('All URLs'),
'authored' => pht('Authored'),
); );
return $names; return $names;
@ -77,10 +77,16 @@ final class PhabricatorPhurlURLSearchEngine
$handles = $viewer->loadHandles(mpull($urls, 'getAuthorPHID')); $handles = $viewer->loadHandles(mpull($urls, 'getAuthorPHID'));
foreach ($urls as $url) { foreach ($urls as $url) {
$name = $url->getName();
$item = id(new PHUIObjectItemView()) $item = id(new PHUIObjectItemView())
->setUser($viewer) ->setUser($viewer)
->setObject($url) ->setObject($url)
->setHeader($viewer->renderHandle($url->getPHID())); ->setObjectName('U'.$url->getID())
->setHeader($name)
->setHref('/U'.$url->getID())
->addAttribute($url->getAlias())
->addAttribute($url->getLongURL());
$list->addItem($item); $list->addItem($item);
} }