revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

LEFT JOIN instead of JOIN for ApplicationSearch ordering

Browse source 
Summary: Ref T4659. Because we JOIN, tasks with no value are filtered out. Instead, LEFT JOIN.

Test Plan: Issued an "Order by" and got all applicable tasks. Adjusted values and saw order change.

Reviewers: btrahan, hach-que

Reviewed By: hach-que

Subscribers: epriestley

Maniphest Tasks: T4659

Differential Revision: https://secure.phabricator.com/D10119
This commit is contained in:
epriestley 2014-08-02 10:17:10 -07:00
parent c4586664b3
commit eafd7070ba
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
View file

@ -570,7 +570,7 @@ abstract class PhabricatorCursorPagedPolicyAwareQuery
$joins[] = qsprintf( $joins[] = qsprintf(
$conn_r, $conn_r,
'JOIN %T %T ON %T.objectPHID = %Q 'LEFT JOIN %T %T ON %T.objectPHID = %Q
AND %T.indexKey = %s', AND %T.indexKey = %s',
$table, $table,
$alias, $alias,