revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Replace dedicated Commit Field with an existing one

Browse source 
Summary: fix T15600

Test Plan: arc diff against this

Reviewers: Sten, O1 Blessed Committers!

Reviewed By: Sten

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15600

Differential Revision: https://we.phorge.it/D25385
This commit is contained in:
Aviv Eyal 2023-08-11 11:27:50 -07:00
parent 8310591523
commit eb0bb17368
3 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/__phutil_library_map__.php
View file

@ -714,7 +714,6 @@ phutil_register_library_map(array(
'DifferentialTabReplacementTestCase' => 'applications/differential/parser/__tests__/DifferentialTabReplacementTestCase.php', 'DifferentialTabReplacementTestCase' => 'applications/differential/parser/__tests__/DifferentialTabReplacementTestCase.php',
'DifferentialTagsCommitMessageField' => 'applications/differential/field/DifferentialTagsCommitMessageField.php', 'DifferentialTagsCommitMessageField' => 'applications/differential/field/DifferentialTagsCommitMessageField.php',
'DifferentialTasksCommitMessageField' => 'applications/differential/field/DifferentialTasksCommitMessageField.php', 'DifferentialTasksCommitMessageField' => 'applications/differential/field/DifferentialTasksCommitMessageField.php',
'DifferentialTestCommitMessageField' => 'applications/differential/field/DifferentialTestCommitMessageField.php',
'DifferentialTestPlanCommitMessageField' => 'applications/differential/field/DifferentialTestPlanCommitMessageField.php', 'DifferentialTestPlanCommitMessageField' => 'applications/differential/field/DifferentialTestPlanCommitMessageField.php',
'DifferentialTestPlanField' => 'applications/differential/customfield/DifferentialTestPlanField.php', 'DifferentialTestPlanField' => 'applications/differential/customfield/DifferentialTestPlanField.php',
'DifferentialTitleCommitMessageField' => 'applications/differential/field/DifferentialTitleCommitMessageField.php', 'DifferentialTitleCommitMessageField' => 'applications/differential/field/DifferentialTitleCommitMessageField.php',
@ -6761,7 +6760,6 @@ phutil_register_library_map(array(
'DifferentialTabReplacementTestCase' => 'PhabricatorTestCase', 'DifferentialTabReplacementTestCase' => 'PhabricatorTestCase',
'DifferentialTagsCommitMessageField' => 'DifferentialCommitMessageField', 'DifferentialTagsCommitMessageField' => 'DifferentialCommitMessageField',
'DifferentialTasksCommitMessageField' => 'DifferentialCommitMessageField', 'DifferentialTasksCommitMessageField' => 'DifferentialCommitMessageField',
'DifferentialTestCommitMessageField' => 'DifferentialCommitMessageField',
'DifferentialTestPlanCommitMessageField' => 'DifferentialCommitMessageField', 'DifferentialTestPlanCommitMessageField' => 'DifferentialCommitMessageField',
'DifferentialTestPlanField' => 'DifferentialCoreCustomField', 'DifferentialTestPlanField' => 'DifferentialCoreCustomField',
'DifferentialTitleCommitMessageField' => 'DifferentialCommitMessageField', 'DifferentialTitleCommitMessageField' => 'DifferentialCommitMessageField',

10
src/applications/differential/field/DifferentialTestCommitMessageField.php
View file

@ -1,10 +0,0 @@
<?php
/**
* This class should only be used for unit tests
*/
final class DifferentialTestCommitMessageField
extends DifferentialCommitMessageField {
public function getFieldName() { return 'Test'; }
public function getFieldOrder() { return 1; }
}

2
src/applications/differential/field/__tests__/DifferentialCommitMessageFieldTestCase.php
View file

@ -29,7 +29,7 @@ final class DifferentialCommitMessageFieldTestCase
} }
public function testRenderFieldValue() { public function testRenderFieldValue() {
$test_object = new DifferentialTestCommitMessageField(); $test_object = new DifferentialRevertPlanCommitMessageField();
$this->assertEqual('foo', $test_object->renderFieldValue('foo'), $this->assertEqual('foo', $test_object->renderFieldValue('foo'),
'Normal strings should be rendered unaltered'); 'Normal strings should be rendered unaltered');