From eb6df7a2091a9477523c97b485277ab68af61a0a Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 22 Nov 2019 11:53:06 -0800 Subject: [PATCH] Remove "phlog()" of exeptions during Conduit calls Summary: Fixes T13465. This "phlog()" made some degree of sense at one time, but is no longer useful or consistent. Get rid of it. See T13465 for discussion. Test Plan: Made a conduit call that hit a policy error, no longer saw error in log. Maniphest Tasks: T13465 Differential Revision: https://secure.phabricator.com/D20924 --- .../conduit/controller/PhabricatorConduitAPIController.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/applications/conduit/controller/PhabricatorConduitAPIController.php b/src/applications/conduit/controller/PhabricatorConduitAPIController.php index cab9276674..d34189125a 100644 --- a/src/applications/conduit/controller/PhabricatorConduitAPIController.php +++ b/src/applications/conduit/controller/PhabricatorConduitAPIController.php @@ -99,9 +99,6 @@ final class PhabricatorConduitAPIController list($error_code, $error_info) = $auth_error; } } catch (Exception $ex) { - if (!($ex instanceof ConduitMethodNotFoundException)) { - phlog($ex); - } $result = null; $error_code = ($ex instanceof ConduitException ? 'ERR-CONDUIT-CALL'