From eba1153e7e0771f4a8d2f8ebe18c2944334abb03 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Sun, 21 Jun 2015 13:38:07 +0100
Subject: [PATCH] [Redesign] Provide more color to object states in headers

Summary: Ref T8099, Now that we have cleaner headers, we can add more pop to important items, like the state of an Object. This makes it easier to just note the color and generally understand the state of the object (closed, returned, accepted, open). @epriestley, I think you previously thought this was a bug, but if it still feels bad, let me know.

Test Plan:
Review Differential, Maniphest, Polls for various object states.

{F520973}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13369
---
 resources/celerity/map.php                          |  6 +++---
 .../constants/DifferentialRevisionStatus.php        |  6 +++---
 webroot/rsrc/css/phui/phui-header-view.css          | 13 ++++++++++++-
 3 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 04992856a5..c57288bdd0 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '604293a7',
+    'core.pkg.css' => '1071965d',
     'core.pkg.js' => 'f1e8abd7',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'fe951924',
@@ -134,7 +134,7 @@ return array(
     'rsrc/css/phui/phui-fontkit.css' => '6790f776',
     'rsrc/css/phui/phui-form-view.css' => 'a0e8f168',
     'rsrc/css/phui/phui-form.css' => '17ce37a9',
-    'rsrc/css/phui/phui-header-view.css' => 'c9c4a432',
+    'rsrc/css/phui/phui-header-view.css' => '318097b5',
     'rsrc/css/phui/phui-icon.css' => '88ba9081',
     'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
@@ -775,7 +775,7 @@ return array(
     'phui-fontkit-css' => '6790f776',
     'phui-form-css' => '17ce37a9',
     'phui-form-view-css' => 'a0e8f168',
-    'phui-header-view-css' => 'c9c4a432',
+    'phui-header-view-css' => '318097b5',
     'phui-icon-view-css' => '88ba9081',
     'phui-image-mask-css' => '5a8b09c8',
     'phui-info-panel-css' => '27ea50a1',
diff --git a/src/applications/differential/constants/DifferentialRevisionStatus.php b/src/applications/differential/constants/DifferentialRevisionStatus.php
index 90c43ccd3f..434c0fd5d2 100644
--- a/src/applications/differential/constants/DifferentialRevisionStatus.php
+++ b/src/applications/differential/constants/DifferentialRevisionStatus.php
@@ -42,11 +42,11 @@ final class DifferentialRevisionStatus extends Phobject {
       ArcanistDifferentialRevisionStatus::NEEDS_REVIEW   =>
         'fa-square-o bluegrey',
       ArcanistDifferentialRevisionStatus::NEEDS_REVISION =>
-        'fa-square-o red',
+        'fa-refresh red',
       ArcanistDifferentialRevisionStatus::CHANGES_PLANNED =>
-        'fa-square-o red',
+        'fa-headphones red',
       ArcanistDifferentialRevisionStatus::ACCEPTED       =>
-        'fa-square-o green',
+        'fa-check green',
       ArcanistDifferentialRevisionStatus::CLOSED         =>
         'fa-check-square-o',
       ArcanistDifferentialRevisionStatus::ABANDONED      =>
diff --git a/webroot/rsrc/css/phui/phui-header-view.css b/webroot/rsrc/css/phui/phui-header-view.css
index 957f8db439..852a614089 100644
--- a/webroot/rsrc/css/phui/phui-header-view.css
+++ b/webroot/rsrc/css/phui/phui-header-view.css
@@ -146,20 +146,31 @@ body .phui-header-shell.phui-bleed-header
 
 .phui-header-subheader .phui-header-status-dark {
   color: {$sh-indigotext};
+  background: {$sh-indigobackground};
   margin-right: 8px;
+  padding: 4px 8px;
+  border-radius: 3px;
 }
 
 .phui-header-subheader .phui-header-status-dark .phui-icon-view {
-  color: {$indigo};
+  color: {$sh-indigotext};
 }
 
 .phui-header-subheader .phui-header-status-red {
   color: {$sh-redtext};
+  background: {$sh-redbackground};
+  margin-right: 8px;
+  padding: 4px 8px;
+  border-radius: 3px;
   margin-right: 8px;
 }
 
 .phui-header-subheader .phui-header-status-green {
   color: {$sh-greentext};
+  background: {$sh-greenbackground};
+  margin-right: 8px;
+  padding: 4px 8px;
+  border-radius: 3px;
   margin-right: 8px;
 }