From ebdd6d3d1179d451d462256f367c9c211709b51b Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 18 Aug 2011 07:32:08 -0700 Subject: [PATCH] Fix a variable typo which prevents metadata from attaching to @mention Differential comments Summary: If you @mention several users, at least one of which is already CC'd, we unset all the CCs and don't attach the "Added CCs: ..." block to the comment. Test Plan: @mentioned two users, one of whom was already CC'd. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason Differential Revision: 827 --- .../differential/editor/comment/DifferentialCommentEditor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/editor/comment/DifferentialCommentEditor.php b/src/applications/differential/editor/comment/DifferentialCommentEditor.php index d213fcf76a..362b3567cb 100644 --- a/src/applications/differential/editor/comment/DifferentialCommentEditor.php +++ b/src/applications/differential/editor/comment/DifferentialCommentEditor.php @@ -351,7 +351,7 @@ class DifferentialCommentEditor { $current_ccs = array_fill_keys($current_ccs, true); foreach ($mention_ccs as $key => $mention_cc) { if (isset($current_ccs[$mention_cc])) { - unset($mention_ccs); + unset($mention_ccs[$key]); } } }