move repository arcanist projects over to new phid stuff

Summary: also submit casual entry for longest class name award with new query class. Ref T2715

Test Plan: phid.query and saw the right arcanist project

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2715

Differential Revision: https://secure.phabricator.com/D6586

src/__phutil_library_map__.php

@@ -1445,6 +1445,7 @@ phutil_register_library_map(array(
     'PhabricatorRepositoryArcanistProject' => 'applications/repository/storage/PhabricatorRepositoryArcanistProject.php',
     'PhabricatorRepositoryArcanistProjectDeleteController' => 'applications/repository/controller/PhabricatorRepositoryArcanistProjectDeleteController.php',
     'PhabricatorRepositoryArcanistProjectEditController' => 'applications/repository/controller/PhabricatorRepositoryArcanistProjectEditController.php',
+    'PhabricatorRepositoryArcanistProjectQuery' => 'applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php',
     'PhabricatorRepositoryAuditRequest' => 'applications/repository/storage/PhabricatorRepositoryAuditRequest.php',
     'PhabricatorRepositoryBranch' => 'applications/repository/storage/PhabricatorRepositoryBranch.php',
     'PhabricatorRepositoryCommit' => 'applications/repository/storage/PhabricatorRepositoryCommit.php',
@@ -1475,6 +1476,7 @@ phutil_register_library_map(array(
     'PhabricatorRepositoryManagementWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementWorkflow.php',
     'PhabricatorRepositoryMercurialCommitChangeParserWorker' => 'applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php',
     'PhabricatorRepositoryMercurialCommitMessageParserWorker' => 'applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php',
+    'PhabricatorRepositoryPHIDTypeArcanistProject' => 'applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php',
     'PhabricatorRepositoryPHIDTypeCommit' => 'applications/repository/phid/PhabricatorRepositoryPHIDTypeCommit.php',
     'PhabricatorRepositoryPHIDTypeRepository' => 'applications/repository/phid/PhabricatorRepositoryPHIDTypeRepository.php',
     'PhabricatorRepositoryPullEngine' => 'applications/repository/engine/PhabricatorRepositoryPullEngine.php',
@@ -3484,9 +3486,14 @@ phutil_register_library_map(array(
       1 => 'PhabricatorPolicyInterface',
       2 => 'PhabricatorMarkupInterface',
     ),
-    'PhabricatorRepositoryArcanistProject' => 'PhabricatorRepositoryDAO',
+    'PhabricatorRepositoryArcanistProject' =>
+    array(
+      0 => 'PhabricatorRepositoryDAO',
+      1 => 'PhabricatorPolicyInterface',
+    ),
     'PhabricatorRepositoryArcanistProjectDeleteController' => 'PhabricatorRepositoryController',
     'PhabricatorRepositoryArcanistProjectEditController' => 'PhabricatorRepositoryController',
+    'PhabricatorRepositoryArcanistProjectQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
     'PhabricatorRepositoryAuditRequest' => 'PhabricatorRepositoryDAO',
     'PhabricatorRepositoryBranch' => 'PhabricatorRepositoryDAO',
     'PhabricatorRepositoryCommit' =>
@@ -3520,6 +3527,7 @@ phutil_register_library_map(array(
     'PhabricatorRepositoryManagementWorkflow' => 'PhutilArgumentWorkflow',
     'PhabricatorRepositoryMercurialCommitChangeParserWorker' => 'PhabricatorRepositoryCommitChangeParserWorker',
     'PhabricatorRepositoryMercurialCommitMessageParserWorker' => 'PhabricatorRepositoryCommitMessageParserWorker',
+    'PhabricatorRepositoryPHIDTypeArcanistProject' => 'PhabricatorPHIDType',
     'PhabricatorRepositoryPHIDTypeCommit' => 'PhabricatorPHIDType',
     'PhabricatorRepositoryPHIDTypeRepository' => 'PhabricatorPHIDType',
     'PhabricatorRepositoryPullEngine' => 'PhabricatorRepositoryEngine',

src/applications/phid/PhabricatorPHIDConstants.php

@@ -6,7 +6,6 @@ final class PhabricatorPHIDConstants {
   const PHID_TYPE_UNKNOWN = '????';
   const PHID_TYPE_MAGIC   = '!!!!';
   const PHID_TYPE_STRY    = 'STRY';
-  const PHID_TYPE_APRJ    = 'APRJ';
   const PHID_TYPE_ACMT    = 'ACMT';
   const PHID_TYPE_DRYR    = 'DRYR';
   const PHID_TYPE_DRYL    = 'DRYL';

src/applications/phid/handle/PhabricatorObjectHandleData.php

@@ -48,13 +48,6 @@ final class PhabricatorObjectHandleData {
 
     switch ($type) {
 
-      case PhabricatorPHIDConstants::PHID_TYPE_APRJ:
-        $project_dao = new PhabricatorRepositoryArcanistProject();
-        $projects = $project_dao->loadAllWhere(
-          'phid IN (%Ls)',
-          $phids);
-        return mpull($projects, null, 'getPHID');
-
       case PhabricatorPHIDConstants::PHID_TYPE_XACT:
         $subtypes = array();
         foreach ($phids as $phid) {
@@ -137,22 +130,6 @@ final class PhabricatorObjectHandleData {
           }
           break;
 
-        case PhabricatorPHIDConstants::PHID_TYPE_APRJ:
-          foreach ($phids as $phid) {
-            $handle = new PhabricatorObjectHandle();
-            $handle->setPHID($phid);
-            $handle->setType($type);
-            if (empty($objects[$phid])) {
-              $handle->setName('Unknown Arcanist Project');
-            } else {
-              $project = $objects[$phid];
-              $handle->setName($project->getName());
-              $handle->setComplete(true);
-            }
-            $handles[$phid] = $handle;
-          }
-          break;
-
         default:
           foreach ($phids as $phid) {
             $handle = new PhabricatorObjectHandle();

src/applications/repository/PhabricatorRepositoryConfigOptions.php

@@ -1,5 +1,8 @@
 <?php
 
+/**
+ * @group repository
+ */
 final class PhabricatorRepositoryConfigOptions
   extends PhabricatorApplicationConfigOptions {
 

src/applications/repository/application/PhabricatorApplicationRepositories.php

@@ -1,5 +1,8 @@
 <?php
 
+/**
+ * @group repository
+ */
 final class PhabricatorApplicationRepositories extends PhabricatorApplication {
 
   public function getBaseURI() {

src/applications/repository/phid/PhabricatorRepositoryPHIDTypeArcanistProject.php

@@ -0,0 +1,43 @@
+<?php
+
+/**
+ * @group repository
+ */
+final class PhabricatorRepositoryPHIDTypeArcanistProject
+  extends PhabricatorPHIDType {
+
+  const TYPECONST = 'APRJ';
+
+  public function getTypeConstant() {
+    return self::TYPECONST;
+  }
+
+  public function getTypeName() {
+    return pht('Arcanist Project');
+  }
+
+  public function newObject() {
+    return new PhabricatorRepositoryArcanistProject();
+  }
+
+  public function loadObjects(
+    PhabricatorObjectQuery $query,
+    array $phids) {
+    return id(new PhabricatorRepositoryArcanistProjectQuery())
+      ->setViewer($query->getViewer())
+      ->withPHIDs($phids)
+      ->execute();
+  }
+
+  public function loadHandles(
+    PhabricatorHandleQuery $query,
+    array $handles,
+    array $objects) {
+
+    foreach ($handles as $phid => $handle) {
+      $project = $objects[$phid];
+      $handle->setName($project->getName());
+    }
+  }
+
+}

src/applications/repository/query/PhabricatorRepositoryArcanistProjectQuery.php

@@ -0,0 +1,59 @@
+<?php
+
+/**
+ * @group repository
+ */
+final class PhabricatorRepositoryArcanistProjectQuery
+  extends PhabricatorCursorPagedPolicyAwareQuery {
+
+  private $ids;
+  private $phids;
+
+  public function withIDs(array $ids) {
+    $this->ids = $ids;
+    return $this;
+  }
+
+  public function withPHIDs(array $phids) {
+    $this->phids = $phids;
+    return $this;
+  }
+
+  protected function loadPage() {
+    $table = new PhabricatorRepositoryArcanistProject();
+    $conn_r = $table->establishConnection('r');
+
+    $data = queryfx_all(
+      $conn_r,
+      'SELECT * FROM %T %Q %Q %Q',
+      $table->getTableName(),
+      $this->buildWhereClause($conn_r),
+      $this->buildOrderClause($conn_r),
+      $this->buildLimitClause($conn_r));
+
+    return $table->loadAllFromArray($data);
+  }
+
+  private function buildWhereClause(AphrontDatabaseConnection $conn_r) {
+    $where = array();
+
+    if ($this->ids) {
+      $where[] = qsprintf(
+        $conn_r,
+        'id IN (%Ld)',
+        $this->ids);
+    }
+
+    if ($this->phids) {
+      $where[] = qsprintf(
+        $conn_r,
+        'phid IN (%Ls)',
+        $this->phids);
+    }
+
+    $where[] = $this->buildPagingClause($conn_r);
+
+    return $this->formatWhereClause($where);
+  }
+
+}

src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php

@@ -1,7 +1,11 @@
 <?php
 
+/**
+ * @group repository
+ */
 final class PhabricatorRepositoryArcanistProject
-  extends PhabricatorRepositoryDAO {
+  extends PhabricatorRepositoryDAO
+  implements PhabricatorPolicyInterface {
 
   protected $name;
   protected $phid;
@@ -22,7 +26,8 @@ final class PhabricatorRepositoryArcanistProject
   }
 
   public function generatePHID() {
-    return PhabricatorPHID::generateNewPHID('APRJ');
+    return PhabricatorPHID::generateNewPHID(
+      PhabricatorRepositoryPHIDTypeArcanistProject::TYPECONST);
   }
 
   public function loadRepository() {
@@ -46,4 +51,28 @@ final class PhabricatorRepositoryArcanistProject
     return $result;
   }
 
+
+
+/* -(  PhabricatorPolicyInterface  )----------------------------------------- */
+
+  public function getCapabilities() {
+    return array(
+      PhabricatorPolicyCapability::CAN_VIEW,
+      PhabricatorPolicyCapability::CAN_EDIT,
+    );
+  }
+
+  public function getPolicy($capability) {
+    switch ($capability) {
+      case PhabricatorPolicyCapability::CAN_VIEW:
+        return PhabricatorPolicies::POLICY_USER;
+      case PhabricatorPolicyCapability::CAN_EDIT:
+        return PhabricatorPolicies::POLICY_ADMIN;
+    }
+  }
+
+  public function hasAutomaticCapability($capability, PhabricatorUser $viewer) {
+    return false;
+  }
+
 }