Audit / Herald - make audits added via herald "required"

Summary: as opposed to "requested". Also re-jigger how the "reason" works so the herald editor can get more specific data rather than a generic message. Fixes T6345 along with companion diff D10726.

Test Plan: made a herald rule to add auditors to a commit and saw it work!

Reviewers: epriestley, chad

Reviewed By: chad

Subscribers: Korvin, epriestley

Maniphest Tasks: T6345

Differential Revision: https://secure.phabricator.com/D10730

src/applications/audit/editor/PhabricatorAuditEditor.php

@@ -160,12 +160,19 @@ final class PhabricatorAuditEditor
             continue;
           }
 
+          if ($this->getIsHeraldEditor()) {
+            $audit_requested = $xaction->getMetadataValue('auditStatus');
+            $audit_reason_map = $xaction->getMetadataValue('auditReasonMap');
+            $audit_reason = $audit_reason_map[$phid];
+          } else {
             $audit_requested = PhabricatorAuditStatusConstants::AUDIT_REQUESTED;
+            $audit_reason = $this->getAuditReasons($phid);
+          }
           $requests[] = id (new PhabricatorRepositoryAuditRequest())
             ->setCommitPHID($object->getPHID())
             ->setAuditorPHID($phid)
             ->setAuditStatus($audit_requested)
-            ->setAuditReasons($this->getAuditReasons($phid))
+            ->setAuditReasons($audit_reason)
             ->save();
         }
 
@@ -849,7 +856,12 @@ final class PhabricatorAuditEditor
     if ($audit_phids) {
       $xactions[] = id(new PhabricatorAuditTransaction())
         ->setTransactionType(PhabricatorAuditActionConstants::ADD_AUDITORS)
-        ->setNewValue(array_fuse(array_keys($audit_phids)));
+        ->setNewValue(array_fuse(array_keys($audit_phids)))
+        ->setMetadataValue(
+          'auditStatus',
+          PhabricatorAuditStatusConstants::AUDIT_REQUIRED)
+        ->setMetadataValue(
+          'auditReasonMap', $this->auditReasonMap);
     }
 
     $cc_phids = $adapter->getAddCCMap();