From eca7dc25f20be9ff20df46f13dda721849369082 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 9 Apr 2018 05:18:58 -0700 Subject: [PATCH] Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly Summary: Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used `phutil_tag()`. Test Plan: Will verify on `secure`. Maniphest Tasks: T13105 Differential Revision: https://secure.phabricator.com/D19311 --- .../diffusion/controller/DiffusionBlameController.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionBlameController.php b/src/applications/diffusion/controller/DiffusionBlameController.php index 758a865e0a..6d922c6322 100644 --- a/src/applications/diffusion/controller/DiffusionBlameController.php +++ b/src/applications/diffusion/controller/DiffusionBlameController.php @@ -145,9 +145,9 @@ final class DiffusionBlameController extends DiffusionController { 'href' => $commit->getURI(), 'sigil' => 'has-tooltip', 'meta' => array( - 'tip' => $this->renderCommitTooltip($commit, $handles), + 'tip' => $this->renderCommitTooltip($commit, $handles), 'align' => 'E', - 'size' => 600, + 'size' => 600, ), ), $commit->getLocalName()); @@ -158,20 +158,19 @@ final class DiffusionBlameController extends DiffusionController { ); if ($revision) { - $revision_link = phutil_tag( + $revision_link = javelin_tag( 'a', array( 'href' => $revision->getURI(), 'sigil' => 'has-tooltip', 'meta' => array( - 'tip' => $this->renderRevisionTooltip($revision, $handles), + 'tip' => $this->renderRevisionTooltip($revision, $handles), 'align' => 'E', - 'size' => 600, + 'size' => 600, ), ), $revision->getMonogram()); - $info = array( $info, ' / ',