From ecae936d97011293737f39a44feaefaf4583fa77 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 12 Dec 2018 16:55:32 -0800 Subject: [PATCH] Fix another qsprintf() straggler in "Has Open Subtasks" Summary: See . Test Plan: Queried for "With Open Subtasks" and "With No Open Subtasks". Reviewers: amckinley, joshuaspence Reviewed By: joshuaspence Subscribers: joshuaspence Differential Revision: https://secure.phabricator.com/D19880 --- src/applications/maniphest/query/ManiphestTaskQuery.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/maniphest/query/ManiphestTaskQuery.php b/src/applications/maniphest/query/ManiphestTaskQuery.php index d1932a7597..fc5097f4d3 100644 --- a/src/applications/maniphest/query/ManiphestTaskQuery.php +++ b/src/applications/maniphest/query/ManiphestTaskQuery.php @@ -641,9 +641,9 @@ final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery { if ($this->hasOpenSubtasks !== null) { if ($this->hasOpenSubtasks) { - $join_type = 'JOIN'; + $join_type = qsprintf($conn, 'JOIN'); } else { - $join_type = 'LEFT JOIN'; + $join_type = qsprintf($conn, 'LEFT JOIN'); } $joins[] = qsprintf(