Stop threading handles through the CustomField + ApplicationSearch pipeline

Summary:
Ref T8441. Ref T7715.

  - These are obsolete after the Viewer/HandlePool changes.
  - These are unused after the typeahead parameterization changes.

Test Plan: `grep`, poked around.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7715, T8441

Differential Revision: https://secure.phabricator.com/D13176

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

@@ -1111,30 +1111,10 @@ abstract class PhabricatorApplicationSearchEngine extends Phobject {
       return;
     }
 
-    $phids = array();
     foreach ($list->getFields() as $field) {
       $key = $this->getKeyForCustomField($field);
       $value = $saved->getParameter($key);
-      $phids[$key] = $field->getRequiredHandlePHIDsForApplicationSearch($value);
+      $field->appendToApplicationSearchForm($this, $form, $value);
-    }
-    $all_phids = array_mergev($phids);
-
-    $handles = array();
-    if ($all_phids) {
-      $handles = id(new PhabricatorHandleQuery())
-        ->setViewer($this->requireViewer())
-        ->withPHIDs($all_phids)
-        ->execute();
-    }
-
-    foreach ($list->getFields() as $field) {
-      $key = $this->getKeyForCustomField($field);
-      $value = $saved->getParameter($key);
-      $field->appendToApplicationSearchForm(
-        $this,
-        $form,
-        $value,
-        array_select_keys($handles, $phids[$key]));
     }
   }
 

src/infrastructure/customfield/field/PhabricatorCustomField.php

@@ -768,49 +768,28 @@ abstract class PhabricatorCustomField {
 
 
   /**
-   * Append search controls to the interface. If you need handles, use
+   * Append search controls to the interface.
-   * @{method:getRequiredHandlePHIDsForApplicationSearch} to get them.
    *
    * @param PhabricatorApplicationSearchEngine Engine constructing the form.
    * @param AphrontFormView The form to update.
    * @param wild Value from the saved query.
-   * @param list<PhabricatorObjectHandle> List of handles.
    * @return void
    * @task appsearch
    */
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
     if ($this->proxy) {
       return $this->proxy->appendToApplicationSearchForm(
         $engine,
         $form,
-        $value,
+        $value);
-        $handles);
     }
     throw new PhabricatorCustomFieldImplementationIncompleteException($this);
   }
 
 
-  /**
-   * Return a list of PHIDs which @{method:appendToApplicationSearchForm} needs
-   * handles for. This is primarily useful if the field stores PHIDs and you
-   * need to (for example) render a tokenizer control.
-   *
-   * @param wild Value from the saved query.
-   * @return list<phid> List of PHIDs.
-   * @task appsearch
-   */
-  public function getRequiredHandlePHIDsForApplicationSearch($value) {
-    if ($this->proxy) {
-      return $this->proxy->getRequiredHandlePHIDsForApplicationSearch($value);
-    }
-    return array();
-  }
-
-
 /* -(  ApplicationTransactions  )-------------------------------------------- */
 
 

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

@@ -282,8 +282,7 @@ abstract class PhabricatorStandardCustomField
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
     return;
   }
 

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php

@@ -65,8 +65,7 @@ final class PhabricatorStandardCustomFieldBool
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
 
     $form->appendChild(
       id(new AphrontFormSelectControl())

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php

@@ -133,8 +133,7 @@ final class PhabricatorStandardCustomFieldDate
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
 
     if (!is_array($value)) {
       $value = array();

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php

@@ -62,8 +62,7 @@ final class PhabricatorStandardCustomFieldInt
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
 
     $form->appendChild(
       id(new AphrontFormTextControl())

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldLink.php

@@ -57,8 +57,7 @@ final class PhabricatorStandardCustomFieldLink
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
 
     $form->appendChild(
       id(new AphrontFormTextControl())

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

@@ -61,13 +61,6 @@ abstract class PhabricatorStandardCustomFieldPHIDs
     }
   }
 
-  public function getRequiredHandlePHIDsForApplicationSearch($value) {
-    if ($value) {
-      return $value;
-    }
-    return array();
-  }
-
   public function getRequiredHandlePHIDsForPropertyView() {
     $value = $this->getFieldValue();
     if ($value) {

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php

@@ -38,8 +38,7 @@ final class PhabricatorStandardCustomFieldSelect
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
 
     if (!is_array($value)) {
       $value = array();

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php

@@ -40,8 +40,7 @@ final class PhabricatorStandardCustomFieldText
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
 
     $form->appendChild(
       id(new AphrontFormTextControl())

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php

@@ -29,8 +29,7 @@ final class PhabricatorStandardCustomFieldUsers
   public function appendToApplicationSearchForm(
     PhabricatorApplicationSearchEngine $engine,
     AphrontFormView $form,
-    $value,
+    $value) {
-    array $handles) {
 
     $control = id(new AphrontFormTokenizerControl())
       ->setLabel($this->getFieldName())