No-op old search indexing migrations which no longer run and have been obsoleted by upgrade "activities"

Summary:
See T13253. After D20200 (which changed the task schema) these migrations no longer run, since the PHP code will expect a column to exist that won't exist until a `20190220.` migration runs.

We don't need these migrations, since anyone upgrading through September 2017 gets a "rebuild search indexes" activity anyway (see T11932). Just no-op them.

Test Plan: Grepped for `queueDocumentForIndexing()` in `autopatches/`, removed all of it.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D20243

resources/sql/autopatches/20151221.search.3.reindex.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new PhabricatorOwnersPackage();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $package) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $package->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160221.almanac.2.devicei.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new AlmanacDevice();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $device) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $device->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160221.almanac.4.servicei.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new AlmanacService();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $service) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $service->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160221.almanac.6.networki.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new AlmanacNetwork();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $network) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $network->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160227.harbormaster.2.plani.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new HarbormasterBuildPlan();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $plan) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $plan->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160303.drydock.2.bluei.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new DrydockBlueprint();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $blueprint) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $blueprint->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160308.nuance.04.sourcei.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new NuanceSource();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $source) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $source->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160406.badges.ngrams.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new PhabricatorBadgesBadge();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $badge) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $badge->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20160927.phurl.ngrams.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new PhabricatorPhurlURL();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $url) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $url->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20161011.conpherence.ngrams.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new ConpherenceThread();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $thread) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $thread->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20161216.dashboard.ngram.02.php

@@ -1,21 +1,3 @@
 <?php
 
-$table_db = new PhabricatorDashboard();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table_db) as $dashboard) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $dashboard->getPHID(),
-    array(
-      'force' => true,
-    ));
-}
-
-$table_dbp = new PhabricatorDashboardPanel();
-
-foreach (new LiskMigrationIterator($table_dbp) as $panel) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $panel->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20170526.milestones.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new PhabricatorProject();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $project) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $project->getPHID(),
-    array(
-      'force' => true,
-    ));
-}

resources/sql/autopatches/20171026.ferret.05.ponder.index.php

@@ -1,11 +1,3 @@
 <?php
 
-$table = new PonderQuestion();
+// This was an old reindexing migration that has been obsoleted. See T13253.
-
-foreach (new LiskMigrationIterator($table) as $question) {
-  PhabricatorSearchWorker::queueDocumentForIndexing(
-    $question->getPHID(),
-    array(
-      'force' => true,
-    ));
-}