revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 21:32:43 +01:00
Code Issues Releases Wiki Activity

Fix two issues with Differential Transactions

Browse source 
Summary: With symbols, the transactions fataled on `getID()`. Also my line
number sorting was a bit goofy.

Auditors: btrahan
This commit is contained in:
epriestley 2014-02-13 15:06:38 -08:00
parent 0159315763
commit ee38e33496
2 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -262,11 +262,19 @@ final class DifferentialRevisionViewController extends DifferentialController {
$revision,
$changesets);
$wrap_id = celerity_generate_unique_node_id();
$comment_view = phutil_tag(
'div',
array(
'id' => $wrap_id,
),
$comment_view);
if ($arc_project) {
Javelin::initBehavior(
'repository-crossreference',
array(
'section' => $comment_view->getID(),
'section' => $wrap_id,
'projects' => $project_phids,
));
}

12
src/applications/differential/view/DifferentialTransactionView.php
View file

@ -96,7 +96,17 @@ final class DifferentialTransactionView
array_keys($changesets));
foreach ($inline_groups as $changeset_id => $group) {
$group = msort($group, 'getLineNumber');
// Sort the group of inlines by line number.
$by_line = array();
foreach ($group as $inline) {
$by_line[] = array(
'line' => $inline->getComment()->getLineNumber().','.
$inline->getComment()->getLineLength(),
'inline' => $inline,
);
}
$by_line = isort($by_line, 'line');
$group = ipull($by_line, 'inline');
$changeset = $changesets[$changeset_id];
$items = array();