From ee599b0201bbf48aff6358dc8d90dffe5d7f0186 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 31 May 2015 15:08:36 -0700 Subject: [PATCH] [Redesign] More header touch ups Summary: Ref T8099, We moved to `phui-header-header` for targeting the internal title in the header vs. the entire header-view. There were some pieces that didn't get converted over. Also resolved some dashboard feed issues. Test Plan: Test lots of dashboards. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13086 --- resources/celerity/map.php | 14 +++++++------- .../css/application/conpherence/widget-pane.css | 2 +- webroot/rsrc/css/phui/phui-feed-story.css | 4 ++++ webroot/rsrc/css/phui/phui-object-box.css | 14 +++++++++++--- 4 files changed, 23 insertions(+), 11 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 0092fa4351..dcd6efc8db 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ */ return array( 'names' => array( - 'core.pkg.css' => '3bcbbf9c', + 'core.pkg.css' => '1b6e6a39', 'core.pkg.js' => 'fbf1d615', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => 'f89b49b6', @@ -52,7 +52,7 @@ return array( 'rsrc/css/application/conpherence/notification.css' => '919974b6', 'rsrc/css/application/conpherence/transaction.css' => '42a457f6', 'rsrc/css/application/conpherence/update.css' => '1099a660', - 'rsrc/css/application/conpherence/widget-pane.css' => '77096740', + 'rsrc/css/application/conpherence/widget-pane.css' => 'eb13f189', 'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4', 'rsrc/css/application/countdown/timer.css' => '86b7b0a0', 'rsrc/css/application/dashboard/dashboard.css' => 'eb458607', @@ -130,7 +130,7 @@ return array( 'rsrc/css/phui/phui-button.css' => 'b995182d', 'rsrc/css/phui/phui-crumbs-view.css' => 'ce840ec2', 'rsrc/css/phui/phui-document.css' => '08f33f08', - 'rsrc/css/phui/phui-feed-story.css' => '92f55311', + 'rsrc/css/phui/phui-feed-story.css' => '06872ae9', 'rsrc/css/phui/phui-fontkit.css' => 'b664ac96', 'rsrc/css/phui/phui-form-view.css' => 'a0e8f168', 'rsrc/css/phui/phui-form.css' => 'f535f938', @@ -140,7 +140,7 @@ return array( 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', 'rsrc/css/phui/phui-info-view.css' => '33e54618', 'rsrc/css/phui/phui-list.css' => 'e448b6ba', - 'rsrc/css/phui/phui-object-box.css' => 'c57e6647', + 'rsrc/css/phui/phui-object-box.css' => '6f449f57', 'rsrc/css/phui/phui-object-item-list-view.css' => '29ded459', 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e', 'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb', @@ -501,7 +501,7 @@ return array( 'conpherence-thread-manager' => '01774ab2', 'conpherence-transaction-css' => '42a457f6', 'conpherence-update-css' => '1099a660', - 'conpherence-widget-pane-css' => '77096740', + 'conpherence-widget-pane-css' => 'eb13f189', 'differential-changeset-view-css' => '582b23ab', 'differential-core-view-css' => '7ac3cabc', 'differential-inline-comment-editor' => 'd4c87bf4', @@ -764,7 +764,7 @@ return array( 'phui-calendar-month-css' => '476be7e0', 'phui-crumbs-view-css' => 'ce840ec2', 'phui-document-view-css' => '08f33f08', - 'phui-feed-story-css' => '92f55311', + 'phui-feed-story-css' => '06872ae9', 'phui-font-icon-base-css' => '3dad2ae3', 'phui-fontkit-css' => 'b664ac96', 'phui-form-css' => 'f535f938', @@ -776,7 +776,7 @@ return array( 'phui-info-view-css' => '33e54618', 'phui-inline-comment-view-css' => 'aa16f165', 'phui-list-view-css' => 'e448b6ba', - 'phui-object-box-css' => 'c57e6647', + 'phui-object-box-css' => '6f449f57', 'phui-object-item-list-view-css' => '29ded459', 'phui-pinboard-view-css' => '2495140e', 'phui-property-list-view-css' => '1baf23eb', diff --git a/webroot/rsrc/css/application/conpherence/widget-pane.css b/webroot/rsrc/css/application/conpherence/widget-pane.css index c850c295e7..52033f70d9 100644 --- a/webroot/rsrc/css/application/conpherence/widget-pane.css +++ b/webroot/rsrc/css/application/conpherence/widget-pane.css @@ -59,7 +59,7 @@ float: none; height: 0px; width: 0px; - margin: 7px 0 0 4px; + margin: 10px 0 0 4px; border-top-color: #000; } diff --git a/webroot/rsrc/css/phui/phui-feed-story.css b/webroot/rsrc/css/phui/phui-feed-story.css index fa63138cd3..561b8f9415 100644 --- a/webroot/rsrc/css/phui/phui-feed-story.css +++ b/webroot/rsrc/css/phui/phui-feed-story.css @@ -2,6 +2,10 @@ * @provides phui-feed-story-css */ +.phabricator-feed-frame .phui-box.phui-feed-story { + border-bottom: 1px solid {$thinblueborder}; +} + .phui-feed-story-head .phui-feed-story-actor-image { width: 35px; height: 35px; diff --git a/webroot/rsrc/css/phui/phui-object-box.css b/webroot/rsrc/css/phui/phui-object-box.css index 7c3e9b0539..d503bed17d 100644 --- a/webroot/rsrc/css/phui/phui-object-box.css +++ b/webroot/rsrc/css/phui/phui-object-box.css @@ -105,19 +105,27 @@ div.phui-object-box.phui-object-box-flush { padding: 0; } +/* eh oh el */ +.phui-object-box .phui-object-box + .phui-object-box { + border-top: 1px solid {$thinblueborder}; +} + .phui-object-box .phui-box-border { border-width: 0; padding: 0; margin: 0; } -.phui-object-box .phui-object-box .phui-header-shell h1 { - padding: 8px; +.phui-object-box .phui-object-box .phui-header-shell .phui-header-view { + padding: 4px 8px; + background-color: {$lightgreybackground}; +} + +.phui-object-box .phui-object-box .phui-header-shell .phui-header-header { font-size: 13px; margin: 0; color: {$darkbluetext}; font-weight: 500; - background-color: {$lightgreybackground}; } .phui-object-box .phui-object-box .phui-header-shell {