From ee823982a46b3cf8d72628f4a7c9a06febc13340 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 27 Aug 2018 10:48:08 -0700 Subject: [PATCH] Remove another old remarkup engine callsite in Config Summary: Ref T13189. Summaries do not appear to be meaningfully rendered with Remarkup so just drop the engine. See D19610 for the previous change in this vein. Test Plan: Viewed config list with option summaries. Reviewers: amckinley Maniphest Tasks: T13189 Differential Revision: https://secure.phabricator.com/D19612 --- .../controller/PhabricatorConfigGroupController.php | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/applications/config/controller/PhabricatorConfigGroupController.php b/src/applications/config/controller/PhabricatorConfigGroupController.php index 7068ddaecc..7a3f77dfea 100644 --- a/src/applications/config/controller/PhabricatorConfigGroupController.php +++ b/src/applications/config/controller/PhabricatorConfigGroupController.php @@ -60,17 +60,10 @@ final class PhabricatorConfigGroupController $db_values = mpull($db_values, null, 'getConfigKey'); } - $engine = id(new PhabricatorMarkupEngine()) - ->setViewer($this->getRequest()->getUser()); - foreach ($options as $option) { - $engine->addObject($option, 'summary'); - } - $engine->process(); - $list = new PHUIObjectItemListView(); $list->setBig(true); foreach ($options as $option) { - $summary = $engine->getOutput($option, 'summary'); + $summary = $option->getSummary(); $item = id(new PHUIObjectItemView()) ->setHeader($option->getKey())