From eec2d145df033a44035ffd025f60201fd271b9b2 Mon Sep 17 00:00:00 2001 From: Joshua Spence Date: Sun, 1 Mar 2015 09:47:10 +1100 Subject: [PATCH] Add abstract `getGroup()` method Summary: In D11722, a `getGroup()` method was added to all subclasses of `PhabricatorApplicationConfigOptions`, but no abstract method was added to the base class. This will fail if a custom `*ConfigOptions` class does not provide a `getGroup()` method, in which case `$group->getGroup()` (in `PhabricatorConfigListController`) will fatal. Test Plan: N/A Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D11756 --- .../config/option/PhabricatorApplicationConfigOptions.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/config/option/PhabricatorApplicationConfigOptions.php b/src/applications/config/option/PhabricatorApplicationConfigOptions.php index 5cee40b294..6982ef513f 100644 --- a/src/applications/config/option/PhabricatorApplicationConfigOptions.php +++ b/src/applications/config/option/PhabricatorApplicationConfigOptions.php @@ -4,6 +4,7 @@ abstract class PhabricatorApplicationConfigOptions extends Phobject { abstract public function getName(); abstract public function getDescription(); + abstract public function getGroup(); abstract public function getOptions(); public function getFontIcon() {