revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 20:10:55 +01:00
Code Issues Releases Wiki Activity

Fix accidental forward dependency in old commit summary migration

Browse source 
Summary: See IRC. This migration inadvertently depends on the columns in the commit table, because it calls `save()`, and thus broke for installs with data after we added the `importStatus` column. Since that was ~9 months after this patch, probably not many installs are affected.

Test Plan: Ran patch locally with `--apply` on data. Had user verify fix.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8152
This commit is contained in:
epriestley 2014-02-06 10:33:54 -08:00
parent 4c7acbafac
commit eef2727ea6
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/sql/patches/20130219.commitsummarymig.php
View file

@ -2,7 +2,9 @@
echo "Backfilling commit summaries...\n";
$commits = new LiskMigrationIterator(new PhabricatorRepositoryCommit());
$table = new PhabricatorRepositoryCommit();
$conn_w = $table->establishConnection('w');
$commits = new LiskMigrationIterator($table);
foreach ($commits as $commit) {
echo 'Filling Commit #'.$commit->getID()."\n";
@ -18,8 +20,12 @@ foreach ($commits as $commit) {
continue;
}
$commit->setSummary($data->getSummary());
$commit->save();
queryfx(
$conn_w,
'UPDATE %T SET summary = %s WHERE id = %d',
$commit->getTableName(),
$data->getSummary(),
$commit->getID());
}
echo "Done.\n";