revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Ensure Maniphest CC PHID list is always a list in maniphest.info

Browse source 
Summary: See T626. Use array_values() to discard keys, for consistency and so
this will always encode as a list (JSON array) over the wire.

Test Plan: Added and removed CCs from a task while calling maniphest.info on it;
CCs worked and I always received a list.

Reviewers: btrahan, jungejason, nh, tuomaspelkonen, aran

Reviewed By: aran

CC: skrul, aran, btrahan, epriestley

Differential Revision: 1118
This commit is contained in:
epriestley 2011-11-16 09:21:11 -08:00
parent 42383214ea
commit ef020f711e
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/maniphest/storage/task/ManiphestTask.php
View file

@ -62,17 +62,21 @@ class ManiphestTask extends ManiphestDAO {
}
public function getCCPHIDs() {
return nonempty($this->ccPHIDs, array());
return array_values(nonempty($this->ccPHIDs, array()));
}
public function setProjectPHIDs(array $phids) {
$this->projectPHIDs = $phids;
$this->projectPHIDs = array_values($phids);
$this->projectsNeedUpdate = true;
return $this;
}
public function getProjectPHIDs() {
return array_values(nonempty($this->projectPHIDs, array()));
}
public function setCCPHIDs(array $phids) {
$this->ccPHIDs = $phids;
$this->ccPHIDs = array_values($phids);
$this->subscribersNeedUpdate = true;
return $this;
}