Use EditEngine for Conpherence preferences

Summary: Ref T4103. Only trick here is hiding the panel if Conpherence is not installed.

Test Plan:
  - Edited Conpherence preferences.
  - Uninstalled Conpherence, saw panel vanish.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16022

src/__phutil_library_map__.php

@@ -6689,7 +6689,7 @@ phutil_register_library_map(array(
     'PhabricatorConfigWelcomeController' => 'PhabricatorConfigController',
     'PhabricatorConpherenceApplication' => 'PhabricatorApplication',
     'PhabricatorConpherenceNotificationsSetting' => 'PhabricatorSelectSetting',
-    'PhabricatorConpherencePreferencesSettingsPanel' => 'PhabricatorSettingsPanel',
+    'PhabricatorConpherencePreferencesSettingsPanel' => 'PhabricatorEditEngineSettingsPanel',
     'PhabricatorConpherenceThreadPHIDType' => 'PhabricatorPHIDType',
     'PhabricatorConsoleApplication' => 'PhabricatorApplication',
     'PhabricatorConsoleContentSource' => 'PhabricatorContentSource',

src/applications/settings/controller/PhabricatorSettingsMainController.php

@@ -80,11 +80,14 @@ final class PhabricatorSettingsMainController
   }
 
   private function buildPanels() {
+    $viewer = $this->getViewer();
     $panels = PhabricatorSettingsPanel::getAllDisplayPanels();
 
     $result = array();
     foreach ($panels as $key => $panel) {
-      $panel->setUser($this->user);
+      $panel
+        ->setViewer($viewer)
+        ->setUser($this->user);
 
       if (!$panel->isEnabled()) {
         continue;

src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php

@@ -1,16 +1,9 @@
 <?php
 
 final class PhabricatorConpherencePreferencesSettingsPanel
-  extends PhabricatorSettingsPanel {
+  extends PhabricatorEditEngineSettingsPanel {
 
-  public function isEnabled() {
+  const PANELKEY = 'conpherence';
-    return PhabricatorApplication::isClassInstalled(
-      'PhabricatorConpherenceApplication');
-  }
-
-  public function getPanelKey() {
-    return 'conpherence';
-  }
 
   public function getPanelName() {
     return pht('Conpherence Preferences');
@@ -20,51 +13,4 @@ final class PhabricatorConpherencePreferencesSettingsPanel
     return PhabricatorSettingsApplicationsPanelGroup::PANELGROUPKEY;
   }
 
-  public function processRequest(AphrontRequest $request) {
-    $user = $request->getUser();
-    $preferences = $user->loadPreferences();
-
-    $pref = PhabricatorUserPreferences::PREFERENCE_CONPH_NOTIFICATIONS;
-
-    if ($request->isFormPost()) {
-      $notifications = $request->getInt($pref);
-      $preferences->setPreference($pref, $notifications);
-      $preferences->save();
-      return id(new AphrontRedirectResponse())
-        ->setURI($this->getPanelURI('?saved=true'));
-    }
-
-    $form = id(new AphrontFormView())
-      ->setUser($user)
-      ->appendChild(
-        id(new AphrontFormSelectControl())
-          ->setLabel(pht('Conpherence Notifications'))
-          ->setName($pref)
-          ->setValue($preferences->getPreference($pref))
-          ->setOptions(
-            array(
-              ConpherenceSettings::EMAIL_ALWAYS
-                => pht('Email Always'),
-              ConpherenceSettings::NOTIFICATIONS_ONLY
-                => pht('Notifications Only'),
-            ))
-          ->setCaption(
-            pht(
-              'Should Conpherence send emails for updates or '.
-              'notifications only? This global setting can be overridden '.
-              'on a per-thread basis within Conpherence.')))
-      ->appendChild(
-        id(new AphrontFormSubmitControl())
-          ->setValue(pht('Save Preferences')));
-
-    $form_box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('Conpherence Preferences'))
-      ->setForm($form)
-      ->setFormSaved($request->getBool('saved'));
-
-    return array(
-      $form_box,
-    );
-  }
-
 }

src/applications/settings/panel/PhabricatorEditEngineSettingsPanel.php

@@ -38,6 +38,12 @@ abstract class PhabricatorEditEngineSettingsPanel
     return $engine->buildResponse();
   }
 
+  final public function isEnabled() {
+    // Only enable the panel if it has any fields.
+    $field_keys = $this->getPanelSettingsKeys();
+    return (bool)$field_keys;
+  }
+
   final public function newEditEnginePage() {
     $field_keys = $this->getPanelSettingsKeys();
     if (!$field_keys) {

src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php

@@ -12,11 +12,21 @@ final class PhabricatorConpherenceNotificationsSetting
     return pht('Conpherence Notifications');
   }
 
+  public function getSettingPanelKey() {
+    return PhabricatorConpherencePreferencesSettingsPanel::PANELKEY;
+  }
+
   protected function getControlInstructions() {
     return pht(
       'Choose the default notification behavior for Conpherence rooms.');
   }
 
+  protected function isEnabledForViewer(PhabricatorUser $viewer) {
+    return PhabricatorApplication::isClassInstalledForViewer(
+      'PhabricatorConpherenceApplication',
+      $viewer);
+  }
+
   public function getSettingDefaultValue() {
     return self::VALUE_CONPHERENCE_EMAIL;
   }