From ef8d4e2126af6adb8fe25449702b3e5e18d1eecc Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 11 Aug 2017 09:47:30 -0700 Subject: [PATCH] Fix an inverted condition for the "Reopen Revision" action Summary: Ref T2543. I converted this condition the wrong way, missing a `!`. I'll cherry-pick this to `stable`. Test Plan: No more "Reopen Revision" action available on open revisions. Reviewers: chad Reviewed By: chad Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18399 --- .../xaction/DifferentialRevisionReopenTransaction.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php b/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php index e2b217603a..7ba20772c7 100644 --- a/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php +++ b/src/applications/differential/xaction/DifferentialRevisionReopenTransaction.php @@ -39,7 +39,7 @@ final class DifferentialRevisionReopenTransaction } protected function validateAction($object, PhabricatorUser $viewer) { - if ($object->isPublished()) { + if (!$object->isPublished()) { throw new Exception( pht( 'You can not reopen this revision because it is not closed. '.