Remove getApplicationObjectTypeName from ApplicationTransactions

Summary:
We can get this out of PHIDType reasonably in all cases and simplify implementation here.

None of these translate correctly anyway so they're basically debugging/development strings.

Test Plan: `grep`, browsed some transactions

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6786

src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php

@@ -34,10 +34,6 @@ final class PhabricatorAuthProviderConfigTransaction
     return null;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('authentication provider');
-  }
-
   public function getIcon() {
     $old = $this->getOldValue();
     $new = $this->getNewValue();

src/applications/config/storage/PhabricatorConfigTransaction.php

@@ -17,11 +17,6 @@ final class PhabricatorConfigTransaction
     return null;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('config');
-  }
-
-
   public function getTitle() {
     $author_phid = $this->getAuthorPHID();
 

src/applications/conpherence/storage/ConpherenceTransaction.php

@@ -17,10 +17,6 @@ final class ConpherenceTransaction extends PhabricatorApplicationTransaction {
     return new ConpherenceTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('conpherence');
-  }
-
   public function getNoEffectDescription() {
     switch ($this->getTransactionType()) {
       case ConpherenceTransactionType::TYPE_PARTICIPANTS:

src/applications/differential/storage/DifferentialTransaction.php

@@ -14,8 +14,4 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction {
     return new DifferentialTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('revision');
-  }
-
 }

src/applications/herald/storage/HeraldRuleTransaction.php

@@ -17,9 +17,5 @@ final class HeraldRuleTransaction
     return new HeraldRuleTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('rule');
-  }
-
 }
 

src/applications/legalpad/storage/LegalpadTransaction.php

@@ -21,10 +21,6 @@ final class LegalpadTransaction extends PhabricatorApplicationTransaction {
     return new LegalpadTransactionView();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('document');
-  }
-
   public function shouldHide() {
     $old = $this->getOldValue();
 

src/applications/macro/storage/PhabricatorMacroTransaction.php

@@ -19,10 +19,6 @@ final class PhabricatorMacroTransaction
     return new PhabricatorMacroTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('macro');
-  }
-
   public function getRequiredHandlePHIDs() {
     $phids = parent::getRequiredHandlePHIDs();
 

src/applications/paste/storage/PhabricatorPasteTransaction.php

@@ -22,10 +22,6 @@ final class PhabricatorPasteTransaction
     return new PhabricatorPasteTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('paste');
-  }
-
   public function getRequiredHandlePHIDs() {
     $phids = parent::getRequiredHandlePHIDs();
 

src/applications/people/storage/PhabricatorUserTransaction.php

@@ -15,9 +15,5 @@ final class PhabricatorUserTransaction
     return null;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('user');
-  }
-
 }
 

src/applications/phlux/storage/PhluxTransaction.php

@@ -17,10 +17,6 @@ final class PhluxTransaction extends PhabricatorApplicationTransaction {
     return null;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('variable');
-  }
-
   public function getTitle() {
     $author_phid = $this->getAuthorPHID();
 

src/applications/pholio/storage/PholioTransaction.php

@@ -21,10 +21,6 @@ final class PholioTransaction extends PhabricatorApplicationTransaction {
     return new PholioTransactionView();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('mock');
-  }
-
   public function getRequiredHandlePHIDs() {
     $phids = parent::getRequiredHandlePHIDs();
     $phids[] = $this->getObjectPHID();

src/applications/phortune/storage/PhortuneAccountTransaction.php

@@ -17,10 +17,6 @@ final class PhortuneAccountTransaction
     return null;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('account');
-  }
-
   public function getTitle() {
     $author_phid = $this->getAuthorPHID();
 

src/applications/phortune/storage/PhortuneProductTransaction.php

@@ -19,10 +19,6 @@ final class PhortuneProductTransaction
     return null;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('product');
-  }
-
   public function getTitle() {
     $author_phid = $this->getAuthorPHID();
 

src/applications/ponder/storage/PonderAnswerTransaction.php

@@ -21,10 +21,6 @@ final class PonderAnswerTransaction
     return new PonderAnswerTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('answer');
-  }
-
   public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();

src/applications/ponder/storage/PonderQuestionTransaction.php

@@ -24,10 +24,6 @@ final class PonderQuestionTransaction
     return new PonderQuestionTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('question');
-  }
-
   public function getTitle() {
     $author_phid = $this->getAuthorPHID();
 

src/applications/releeph/storage/ReleephBranchTransaction.php

@@ -11,9 +11,5 @@ final class ReleephBranchTransaction
     return ReleephPHIDTypeBranch::TYPECONST;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('branch');
-  }
-
 }
 

src/applications/releeph/storage/ReleephProjectTransaction.php

@@ -11,9 +11,5 @@ final class ReleephProjectTransaction
     return ReleephPHIDTypeProject::TYPECONST;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('project');
-  }
-
 }
 

src/applications/releeph/storage/ReleephRequestTransaction.php

@@ -23,10 +23,6 @@ final class ReleephRequestTransaction
     return new ReleephRequestTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('releeph request');
-  }
-
   public function hasChangeDetails() {
     switch ($this->getTransactionType()) {
       default;

src/applications/repository/storage/PhabricatorRepositoryTransaction.php

@@ -19,10 +19,6 @@ final class PhabricatorRepositoryTransaction
     return null;
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('repository');
-  }
-
   public function getTitle() {
     $author_phid = $this->getAuthorPHID();
 

src/applications/slowvote/storage/PhabricatorSlowvoteTransaction.php

@@ -20,10 +20,6 @@ final class PhabricatorSlowvoteTransaction
     return new PhabricatorSlowvoteTransactionComment();
   }
 
-  public function getApplicationObjectTypeName() {
-    return pht('vote');
-  }
-
   public function shouldHide() {
     $old = $this->getOldValue();
     $new = $this->getNewValue();

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

@@ -30,7 +30,17 @@ abstract class PhabricatorApplicationTransaction
   private $transactionGroup = array();
 
   abstract public function getApplicationTransactionType();
-  abstract public function getApplicationObjectTypeName();
+
+  private function getApplicationObjectTypeName() {
+    $types = PhabricatorPHIDType::getAllTypes();
+
+    $type = idx($types, $this->getApplicationTransactionType());
+    if ($type) {
+      return $type->getTypeName();
+    }
+
+    return pht('Object');
+  }
 
   public function getApplicationTransactionCommentObject() {
     throw new Exception("Not implemented!");