From f0ade1be1c57479d4996617a087a1f2021108989 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 8 Jan 2015 14:02:14 -0800 Subject: [PATCH] Stop advising users to use `npm -g` to install websockets Summary: Fixes T6910. This advice is bad, doesn't work, and was based on me havng an outdated or incorrect understanding of Node and npm. Test Plan: Read documentation. Reviewers: richardvanvelzen, btrahan, chad, joshuaspence Reviewed By: chad, joshuaspence Subscribers: epriestley Maniphest Tasks: T6910 Differential Revision: https://secure.phabricator.com/D11285 --- src/docs/user/configuration/notifications.diviner | 12 +++--------- support/aphlict/server/aphlict_server.js | 3 ++- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/docs/user/configuration/notifications.diviner b/src/docs/user/configuration/notifications.diviner index 600c901540..71609826c9 100644 --- a/src/docs/user/configuration/notifications.diviner +++ b/src/docs/user/configuration/notifications.diviner @@ -41,16 +41,10 @@ The notification server uses Node.js, so you'll need to install it first. To install Node.js, follow the instructions on [[ http://nodejs.org | nodejs.org ]]. -You will also need to install the `ws` module for Node. After installing -Node, run `npm install -g ws` to install it. +You will also need to install the `ws` module for Node. This needs to be +installed into the notification server directory: - name="(Option 1, Recommended) Install 'ws' Module Globally" - $ npm install -g ws # Global Install - -If you prefer, you can also install it locally in the `support/aphlict/server/` -directory: - - name="(Option 2) Install 'ws' Module Locally" + phabricator/ $ cd support/aphlict/server/ phabricator/support/aphlict/server/ $ npm install ws Once Node.js and the `ws` module are installed, you're ready to start the diff --git a/support/aphlict/server/aphlict_server.js b/support/aphlict/server/aphlict_server.js index a662ad4304..d4c94ca831 100644 --- a/support/aphlict/server/aphlict_server.js +++ b/support/aphlict/server/aphlict_server.js @@ -52,7 +52,8 @@ try { } catch (ex) { throw new Error( 'You need to install the Node.js "ws" module for websocket support. ' + - 'Usually, you can do this with `npm install -g ws`. ' + ex.toString()); + 'See "Notifications User Guide: Setup and Configuration" in the ' + + 'documentation for instructions. ' + ex.toString()); } var ssl_config = {