From f0ae75c9916a59c5005f4618af2d2b146e56c02f Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 23 Mar 2019 10:41:06 -0700 Subject: [PATCH] Fix an issue with "nextPage()" on worker trigger queries Ref T13266. We never page these queries, and previously never reached the "nextPage()" method. The call order changed recently and this method is now reachable. For now, just no-op it rather than throwing. --- .../daemon/workers/query/PhabricatorWorkerTriggerQuery.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php index 87c16a48c5..8ca12d60e4 100644 --- a/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php +++ b/src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php @@ -70,7 +70,11 @@ final class PhabricatorWorkerTriggerQuery protected function nextPage(array $page) { // NOTE: We don't implement paging because we don't currently ever need // it and paging ORDER_EXECUTION is a hassle. - throw new PhutilMethodNotImplementedException(); + + // (Before T13266, we raised an exception here, but since "nextPage()" is + // now called even if we don't page we can't do that anymore. Just do + // nothing instead.) + return null; } protected function loadPage() {