revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
Code Issues Releases Wiki Activity

Fix an issue with "nextPage()" on worker trigger queries

Browse source 
Ref T13266. We never page these queries, and previously never reached the
"nextPage()" method. The call order changed recently and this method is now
reachable. For now, just no-op it rather than throwing.
This commit is contained in:
epriestley 2019-03-23 10:41:06 -07:00
parent aae7bdbbdd
commit f0ae75c991
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php
View file

@ -70,7 +70,11 @@ final class PhabricatorWorkerTriggerQuery
protected function nextPage(array $page) { protected function nextPage(array $page) {
// NOTE: We don't implement paging because we don't currently ever need // NOTE: We don't implement paging because we don't currently ever need
// it and paging ORDER_EXECUTION is a hassle. // it and paging ORDER_EXECUTION is a hassle.
throw new PhutilMethodNotImplementedException();
// (Before T13266, we raised an exception here, but since "nextPage()" is
// now called even if we don't page we can't do that anymore. Just do
// nothing instead.)
return null;
} }
protected function loadPage() { protected function loadPage() {