From f0e7c65d8835ed4c57bb8fb85da5196c4624835c Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 4 Aug 2015 12:45:50 -0700 Subject: [PATCH] Set a max-height on codeblocks in Conpherence Summary: Code blocks in Conpherence can be massive and disruptive to a chat-like experience. This caps the height. Test Plan: Add a ginormous code block to Conpherence, see it hit max-height Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D13790 --- resources/celerity/map.php | 4 ++-- webroot/rsrc/css/application/conpherence/message-pane.css | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 372eefe09f..f177c19d22 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -48,7 +48,7 @@ return array( 'rsrc/css/application/config/unhandled-exception.css' => '4c96257a', 'rsrc/css/application/conpherence/durable-column.css' => '86396117', 'rsrc/css/application/conpherence/menu.css' => 'f99fee4c', - 'rsrc/css/application/conpherence/message-pane.css' => '2c16d204', + 'rsrc/css/application/conpherence/message-pane.css' => 'dd4f8a3b', 'rsrc/css/application/conpherence/notification.css' => '6cdcc253', 'rsrc/css/application/conpherence/transaction.css' => '85d0974c', 'rsrc/css/application/conpherence/update.css' => 'faf6be09', @@ -514,7 +514,7 @@ return array( 'config-welcome-css' => '6abd79be', 'conpherence-durable-column-view' => '86396117', 'conpherence-menu-css' => 'f99fee4c', - 'conpherence-message-pane-css' => '2c16d204', + 'conpherence-message-pane-css' => 'dd4f8a3b', 'conpherence-notification-css' => '6cdcc253', 'conpherence-thread-manager' => '01774ab2', 'conpherence-transaction-css' => '85d0974c', diff --git a/webroot/rsrc/css/application/conpherence/message-pane.css b/webroot/rsrc/css/application/conpherence/message-pane.css index 9da3de6d7f..886700ccf5 100644 --- a/webroot/rsrc/css/application/conpherence/message-pane.css +++ b/webroot/rsrc/css/application/conpherence/message-pane.css @@ -344,3 +344,7 @@ height: 24px; width: 100%; } + +.conpherence-message .phabricator-remarkup .remarkup-code-block pre { + max-height: 200px; +}