From f163d83935d9916e6ff8a73068d4f5e5ff797f17 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 11 Feb 2016 11:21:34 -0800 Subject: [PATCH] Don't link commit uri in Crumbs Summary: These are not needed I think? and handy for cut and paste. Fixes T7628 Test Plan: cut and paste easier from commit hash. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Maniphest Tasks: T7628 Differential Revision: https://secure.phabricator.com/D15245 --- .../diffusion/controller/DiffusionController.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php index a3c661a26d..00bb0ce4d4 100644 --- a/src/applications/diffusion/controller/DiffusionController.php +++ b/src/applications/diffusion/controller/DiffusionController.php @@ -147,7 +147,7 @@ abstract class DiffusionController extends PhabricatorController { $crumb_list[] = $crumb; $stable_commit = $drequest->getStableCommit(); - $commit_name = $repository->formatCommitName($stable_commit); + $commit_name = $repository->formatCommitName($stable_commit, $local = true); $commit_uri = $repository->getCommitURI($stable_commit); if ($spec['tags']) { @@ -171,8 +171,7 @@ abstract class DiffusionController extends PhabricatorController { if ($spec['commit']) { $crumb = id(new PHUICrumbView()) - ->setName($commit_name) - ->setHref($commit_uri); + ->setName($commit_name); $crumb_list[] = $crumb; return $crumb_list; }