From f1d1ec3d77f1ec41e92f2ec365f83c54d41d00ef Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sun, 5 Apr 2020 09:02:36 -0700
Subject: [PATCH] Add an "isDone" flag to "transaction.search" for Differential
 inline comments

Summary: See PHI1684. Expose the published state of the "Done" checkbox to the API.

Test Plan: Made API calls on a comment in all four states, got correct published states via the API in all cases.

Differential Revision: https://secure.phabricator.com/D21059
---
 .../xaction/DifferentialRevisionInlineTransaction.php    | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php b/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
index 35d5034033..8ad4e00762 100644
--- a/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
@@ -38,6 +38,14 @@ final class DifferentialRevisionInlineTransaction
     $changeset = $data[$comment->getChangesetID()];
     $diff = $changeset->getDiff();
 
+    $is_done = false;
+    switch ($comment->getFixedState()) {
+      case PhabricatorInlineCommentInterface::STATE_DONE:
+      case PhabricatorInlineCommentInterface::STATE_UNDRAFT:
+        $is_done = true;
+        break;
+    }
+
     return array(
       'diff' => array(
         'id' => (int)$diff->getID(),
@@ -47,6 +55,7 @@ final class DifferentialRevisionInlineTransaction
       'line' => (int)$comment->getLineNumber(),
       'length' => (int)($comment->getLineLength() + 1),
       'replyToCommentPHID' => $comment->getReplyToCommentPHID(),
+      'isDone' => $is_done,
     );
   }