Return $this from setter methods

Summary: Return `$this` from setter methods for consistency. I started writing a [[https://secure.phabricator.com/differential/diff/32506/ | linter rule]] to detect this, but I don't think it is trivial to do this properly.

Test Plan: Eyeball it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13422

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

@@ -88,6 +88,7 @@ abstract class PhabricatorAphlictManagementWorkflow
 
   final protected function setDebug($debug) {
     $this->debug = $debug;
+    return $this;
   }
 
   public static function requireExtensions() {

src/applications/differential/parser/DifferentialChangesetParser.php

@@ -257,6 +257,7 @@ final class DifferentialChangesetParser extends Phobject {
 
     $this->originalLeft = $left;
     $this->originalRight = $right;
+    return $this;
   }
 
   public function diffOriginals() {

src/applications/diviner/atom/DivinerAtom.php

@@ -370,6 +370,7 @@ final class DivinerAtom extends Phobject {
 
   public function setProperty($key, $value) {
     $this->properties[$key] = $value;
+    return $this;
   }
 
   public function getProperties() {

src/applications/legalpad/editor/LegalpadDocumentEditor.php

@@ -15,6 +15,7 @@ final class LegalpadDocumentEditor
 
   private function setIsContribution($is_contribution) {
     $this->isContribution = $is_contribution;
+    return $this;
   }
 
   private function isContribution() {

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

@@ -20,6 +20,7 @@ final class PhabricatorMetaMTAMailBody extends Phobject {
 
   public function setViewer($viewer) {
     $this->viewer = $viewer;
+    return $this;
   }
 
 /* -(  Composition  )-------------------------------------------------------- */

src/applications/paste/view/PasteEmbedView.php

@@ -24,6 +24,7 @@ final class PasteEmbedView extends AphrontView {
 
   public function setLines($lines) {
     $this->lines = $lines;
+    return $this;
   }
 
   public function render() {

src/applications/releeph/editor/ReleephRequestTransactionalEditor.php

@@ -302,6 +302,8 @@ final class ReleephRequestTransactionalEditor
             'RQ'.$id));
         break;
     }
+
+    return $this;
   }
 
 }

src/applications/releeph/field/specification/ReleephFieldSpecification.php

@@ -110,6 +110,7 @@ abstract class ReleephFieldSpecification
       $this->getRequiredStorageKey());
     $this->validate($value);
     $this->setValue($value);
+    return $this;
   }
 
 

src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php

@@ -118,6 +118,7 @@ abstract class ReleephLevelFieldSpecification
         pht("Unknown %s level name '%s'", $label, $name));
     }
     $this->setValue($level);
+    return $this;
   }
 
   private $nameMap = array();

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

@@ -438,6 +438,8 @@ final class PhabricatorRepositoryRefEngine
         PhabricatorWorker::scheduleTask($class, $data);
       }
     }
+
+    return $this;
   }
 
 

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

@@ -513,6 +513,8 @@ abstract class PhabricatorApplicationSearchEngine extends Phobject {
         PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
         $constraints);
     }
+
+    return $this;
   }
 
 

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

@@ -42,6 +42,7 @@ abstract class PhabricatorStandardCustomFieldPHIDs
       }
     }
     $this->setFieldValue($value);
+    return $this;
   }
 
   public function readApplicationSearchValueFromRequest(