1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00

Fix Remarkup styling in Maniphest and Differential

Summary:
This makes some of the line spacing, paragraph spacing and layout
less terrible. In particular, fixes code blocks inside Differential inline
comments.

Test Plan:
Looked at Maniphest Tasks, Differential Revisions and Differential
inline comments with various flavors of remarkup in them.

Reviewed By: jungejason
Reviewers: tuomaspelkonen, jungejason
CC: jungejason
Differential Revision: 89
This commit is contained in:
epriestley 2011-03-29 21:38:05 -07:00
parent aa5c82df75
commit f249ffc882
3 changed files with 12 additions and 8 deletions

View file

@ -140,7 +140,9 @@ final class DifferentialInlineCommentView extends AphrontView {
'<span class="differential-inline-comment-line">'.$line.'</span>'.
phutil_escape_html($handles[$inline->getAuthorPHID()]->getName()).
'</div>'.
$content);
'<div class="phabricator-remarkup">'.
$content.
'</div>');
return $this->scaffoldMarkup($markup);
}

View file

@ -71,9 +71,3 @@
padding: 4px 1em;
background: #f3f3f3;
}
.maniphest-task-description p,
.maniphest-transaction-comments p {
margin: .25em 0 .5em;
}

View file

@ -2,8 +2,12 @@
* @provides phabricator-remarkup-css
*/
.phabricator-remarkup {
line-height: 1.45em;
}
.phabricator-remarkup p {
margin: 1em 0;
margin: 0 0 .75em;
}
.phabricator-remarkup code {
@ -28,3 +32,7 @@
margin: 1em 0 1em 3em;
}
.phabricator-remarkup h1,
.phabricator-remarkup h2 {
margin: .75em 0 .5em;
}