revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 02:02:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/config/check/PhabricatorSetupCheck.php:125]
```

Closes T15823

Test Plan: Run `./bin/cache purge --all`, check any Phorge page in browser before and after applying this patch.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15823

Differential Revision: https://we.phorge.it/D25633
This commit is contained in:
Andre Klapper 2024-05-10 12:21:52 +02:00
parent b6f132f04f
commit f2a01dca39
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/config/check/PhabricatorSetupCheck.php
View file

@ -122,7 +122,7 @@ abstract class PhabricatorSetupCheck extends Phobject {
$db_cache = new PhabricatorKeyValueDatabaseCache(); $db_cache = new PhabricatorKeyValueDatabaseCache();
try { try {
$value = $db_cache->getKey('phabricator.setup.issue-keys'); $value = $db_cache->getKey('phabricator.setup.issue-keys');
if (!strlen($value)) { if (!phutil_nonempty_string($value)) {
return null; return null;
} }
return phutil_json_decode($value); return phutil_json_decode($value);