From f2d9d936268e855c23fc35c8928b471c82fb216f Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Mon, 17 Sep 2018 15:10:29 -0700
Subject: [PATCH] (stable) Fix fatal in rendering Phriction "Moved Away"
 stories

Summary:
Ref T13202. See PHI881. These stories have bad rendering methods, but they didn't previously render into the timeilne (since Phriction documents didn't have a timeline).

Update the rendering to work.

The rendered outcome isn't great (it isn't very clear or explicit about exactly what moved where), but I'll fix that in a followup. This is a net improvement since it doesn't fatal the page, at least.

Test Plan:
  - Moved page "X" to "Y".
  - Viewed the old page "X".
  - Before patch: bad timeline story would fatal rendering.
  - After patch: story renders, at least, just not great.

Reviewers: amckinley

Maniphest Tasks: T13202

Differential Revision: https://secure.phabricator.com/D19682
---
 .../xaction/PhrictionDocumentMoveAwayTransaction.php      | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php b/src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php
index 09ec56dd25..af77a5adea 100644
--- a/src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php
+++ b/src/applications/phriction/xaction/PhrictionDocumentMoveAwayTransaction.php
@@ -38,19 +38,19 @@ final class PhrictionDocumentMoveAwayTransaction
     $new = $this->getNewValue();
 
     return pht(
-      '%s moved this document to %s',
+      '%s moved this document to %s.',
       $this->renderAuthor(),
-      $this->renderHandleLink($new['phid']));
+      $this->renderObject($new['phid']));
   }
 
   public function getTitleForFeed() {
     $new = $this->getNewValue();
 
     return pht(
-      '%s moved %s to %s',
+      '%s moved %s to %s.',
       $this->renderAuthor(),
       $this->renderObject(),
-      $this->renderHandleLink($new['phid']));
+      $this->renderObject($new['phid']));
   }
 
   public function getIcon() {