revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-05 12:21:02 +01:00
Code Issues Releases Wiki Activity

A few Macro bugs

Browse source 
Summary: Consistent look for panels, test for mobile, forms consistency

Test Plan: test Macro on web and iOS sim

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5959
This commit is contained in:
Chad Little 2013-05-17 16:01:19 -07:00
parent 07ad4d154c
commit f2efda75b5
3 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/macro/controller/PhabricatorMacroEditController.php
View file

@ -156,6 +156,7 @@ final class PhabricatorMacroEditController
$form $form
->setEncType('multipart/form-data') ->setEncType('multipart/form-data')
->setFlexible(true)
->appendChild( ->appendChild(
id(new AphrontFormTextControl()) id(new AphrontFormTextControl())
->setLabel(pht('Name')) ->setLabel(pht('Name'))
@ -219,7 +220,7 @@ final class PhabricatorMacroEditController
if ($macro->getID()) { if ($macro->getID()) {
$title = pht('Edit Image Macro'); $title = pht('Edit Image Macro');
$crumb = pht('Edit'); $crumb = pht('Edit Macro');
$crumbs->addCrumb( $crumbs->addCrumb(
id(new PhabricatorCrumbView()) id(new PhabricatorCrumbView())
@ -227,7 +228,7 @@ final class PhabricatorMacroEditController
->setName(pht('Macro "%s"', $macro->getName()))); ->setName(pht('Macro "%s"', $macro->getName())));
} else { } else {
$title = pht('Create Image Macro'); $title = pht('Create Image Macro');
$crumb = pht('Create'); $crumb = pht('Create Macro');
} }
$crumbs->addCrumb( $crumbs->addCrumb(
@ -266,17 +267,11 @@ final class PhabricatorMacroEditController
$upload = array($upload_header, $upload_form); $upload = array($upload_header, $upload_form);
} }
$panel = new AphrontPanelView();
$panel->setHeader(pht('Create New Macro'));
$panel->setNoBackground();
$panel->appendChild($form);
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
return $this->buildApplicationPage( return $this->buildApplicationPage(
array( array(
$crumbs, $crumbs,
$error_view, $error_view,
$panel, $form,
$upload, $upload,
), ),
array( array(

1
src/applications/macro/controller/PhabricatorMacroListController.php
View file

@ -67,6 +67,7 @@ final class PhabricatorMacroListController
$filter_form = id(new AphrontFormView()) $filter_form = id(new AphrontFormView())
->setMethod('GET') ->setMethod('GET')
->setUser($request->getUser()) ->setUser($request->getUser())
->setNoShading(true)
->appendChild( ->appendChild(
id(new AphrontFormTextControl()) id(new AphrontFormTextControl())
->setName('name') ->setName('name')

1
src/applications/macro/controller/PhabricatorMacroViewController.php
View file

@ -105,6 +105,7 @@ final class PhabricatorMacroViewController
), ),
array( array(
'title' => $title_short, 'title' => $title_short,
'device' => true,
)); ));
} }