revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

[Redesign] Use status icons in Maniphest task list

Browse source 
Summary: Ref T8099, Fixes T8339. This lets us pull in the status icon and display in lists and object headers.

Test Plan: Look at a list of open and closed tasks, see icons match state (duplicate, spite, defaults).

Reviewers: epriestley, btrahan

Reviewed By: btrahan

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099, T8339

Differential Revision: https://secure.phabricator.com/D13490
This commit is contained in:
Chad Little 2015-06-30 13:42:27 -07:00
parent 09d392fdbb
commit f2f168cceb
2 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/constants/ManiphestTaskStatus.php
View file

@ -174,7 +174,7 @@ final class ManiphestTaskStatus extends ManiphestConstants {
} }
if (self::isOpenStatus($status)) { if (self::isOpenStatus($status)) {
return 'fa-square-o'; return 'fa-exclamation-circle';
} else { } else {
return 'fa-check-square-o'; return 'fa-check-square-o';
} }

9
src/applications/maniphest/view/ManiphestTaskListView.php
View file

@ -74,15 +74,14 @@ final class ManiphestTaskListView extends ManiphestView {
$status_name = idx($status_map, $task->getStatus()); $status_name = idx($status_map, $task->getStatus());
$tooltip = pht('%s, %s', $status_name, $pri); $tooltip = pht('%s, %s', $status_name, $pri);
// TODO: redesign-2015 move icon map to maniphest.statuses $icon = ManiphestTaskStatus::getStatusIcon($task->getStatus());
$icon = 'fa-exclamation-circle '; $color = idx($color_map, $task->getPriority(), 'grey');
$icon .= idx($color_map, $task->getPriority(), 'grey');
if ($task->isClosed()) { if ($task->isClosed()) {
$item->setDisabled(true); $item->setDisabled(true);
$icon = 'fa-check-square-o grey'; $color = 'grey';
} }
$item->setStatusIcon($icon, $tooltip); $item->setStatusIcon($icon.' '.$color, $tooltip);
$item->addIcon( $item->addIcon(
'none', 'none',