mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-18 21:02:41 +01:00
Removed all instances of getIconURI
Summary: Fixes T11541. `PhabricatorApplication::getIconURI()` has been returning only null for a while (I assume in preparation to remove it). I removed the method and all the remaining call sites. Test Plan: Removed the method and then clicked around. Things didn't explode! Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, yelirekim Maniphest Tasks: T11541 Differential Revision: https://secure.phabricator.com/D16470
This commit is contained in:
parent
b75cea55a7
commit
f2f896c761
3 changed files with 3 additions and 13 deletions
|
@ -151,10 +151,6 @@ abstract class PhabricatorApplication
|
||||||
return $this->getBaseURI().ltrim($path, '/');
|
return $this->getBaseURI().ltrim($path, '/');
|
||||||
}
|
}
|
||||||
|
|
||||||
public function getIconURI() {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
public function getIcon() {
|
public function getIcon() {
|
||||||
return 'fa-puzzle-piece';
|
return 'fa-puzzle-piece';
|
||||||
}
|
}
|
||||||
|
|
|
@ -36,7 +36,6 @@ final class PhabricatorApplicationDatasource
|
||||||
->setPriorityString($application->getName())
|
->setPriorityString($application->getName())
|
||||||
->setDisplayName($application->getName())
|
->setDisplayName($application->getName())
|
||||||
->setDisplayType($application->getShortDescription())
|
->setDisplayType($application->getShortDescription())
|
||||||
->setImageuRI($application->getIconURI())
|
|
||||||
->setPriorityType('apps')
|
->setPriorityType('apps')
|
||||||
->setImageSprite('phabricator-search-icon '.$img)
|
->setImageSprite('phabricator-search-icon '.$img)
|
||||||
->setIcon($application->getIcon())
|
->setIcon($application->getIcon())
|
||||||
|
|
|
@ -109,14 +109,9 @@ final class PhabricatorApplicationLaunchView extends AphrontTagView {
|
||||||
$classes = array();
|
$classes = array();
|
||||||
$classes[] = 'phabricator-application-launch-icon';
|
$classes[] = 'phabricator-application-launch-icon';
|
||||||
$styles = array();
|
$styles = array();
|
||||||
|
|
||||||
if ($application->getIconURI()) {
|
|
||||||
$styles[] = 'background-image: url('.$application->getIconURI().')';
|
|
||||||
} else {
|
|
||||||
$classes[] = $application->getIcon();
|
$classes[] = $application->getIcon();
|
||||||
$classes[] = 'phui-icon-view';
|
$classes[] = 'phui-icon-view';
|
||||||
$classes[] = 'phui-font-fa';
|
$classes[] = 'phui-font-fa';
|
||||||
}
|
|
||||||
|
|
||||||
$icon = phutil_tag(
|
$icon = phutil_tag(
|
||||||
'span',
|
'span',
|
||||||
|
|
Loading…
Reference in a new issue