Removed all instances of getIconURI

Summary: Fixes T11541. `PhabricatorApplication::getIconURI()` has been returning only null for a while (I assume in preparation to remove it). I removed the method and all the remaining call sites.

Test Plan: Removed the method and then clicked around. Things didn't explode!

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, yelirekim

Maniphest Tasks: T11541

Differential Revision: https://secure.phabricator.com/D16470

src/applications/base/PhabricatorApplication.php

@@ -151,10 +151,6 @@ abstract class PhabricatorApplication
     return $this->getBaseURI().ltrim($path, '/');
   }
 
-  public function getIconURI() {
-    return null;
-  }
-
   public function getIcon() {
     return 'fa-puzzle-piece';
   }

src/applications/meta/typeahead/PhabricatorApplicationDatasource.php

@@ -36,7 +36,6 @@ final class PhabricatorApplicationDatasource
         ->setPriorityString($application->getName())
         ->setDisplayName($application->getName())
         ->setDisplayType($application->getShortDescription())
-        ->setImageuRI($application->getIconURI())
         ->setPriorityType('apps')
         ->setImageSprite('phabricator-search-icon '.$img)
         ->setIcon($application->getIcon())

src/applications/meta/view/PhabricatorApplicationLaunchView.php

@@ -109,14 +109,9 @@ final class PhabricatorApplicationLaunchView extends AphrontTagView {
       $classes = array();
       $classes[] = 'phabricator-application-launch-icon';
       $styles = array();
-
+      $classes[] = $application->getIcon();
-      if ($application->getIconURI()) {
+      $classes[] = 'phui-icon-view';
-        $styles[] = 'background-image: url('.$application->getIconURI().')';
+      $classes[] = 'phui-font-fa';
-      } else {
-        $classes[] = $application->getIcon();
-        $classes[] = 'phui-icon-view';
-        $classes[] = 'phui-font-fa';
-      }
 
       $icon = phutil_tag(
         'span',