revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Issue CREATE DATABASE before ALTER TABLE in patch 88

Browse source 
Summary:
Sometimes the SQL account may not have CREATE DATABASE privileges, so try to
fail this script immediately rather than having it work halfway if the
permission is missing.

This is just a minor tweak to try to slightly improve some cases, the long term
fix is T345 but that's a good deal more work than this.

Test Plan: Visually inspected patch; trivial change.

Reviewers: jungejason, btrahan, skrul

Reviewed By: skrul

CC: aran, skrul

Differential Revision: https://secure.phabricator.com/D1287
This commit is contained in:
epriestley 2011-12-27 16:24:50 -08:00
parent 1a1da7d6c2
commit f30f4fa713
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/sql/patches/088.audit.sql
View file

@ -1,11 +1,11 @@
CREATE DATABASE IF NOT EXISTS phabricator_audit;
ALTER TABLE phabricator_owners.owners_packagecommitrelationship ALTER TABLE phabricator_owners.owners_packagecommitrelationship
ADD COLUMN `auditStatus` varchar(64) NOT NULL, ADD COLUMN `auditStatus` varchar(64) NOT NULL,
ADD COLUMN `auditReasons` longtext NOT NULL, ADD COLUMN `auditReasons` longtext NOT NULL,
DROP KEY `packagePHID`, DROP KEY `packagePHID`,
ADD KEY `packagePHID` (`packagePHID`, `auditStatus`, `id`); ADD KEY `packagePHID` (`packagePHID`, `auditStatus`, `id`);
CREATE DATABASE IF NOT EXISTS phabricator_audit;
CREATE TABLE IF NOT EXISTs phabricator_audit.audit_comment ( CREATE TABLE IF NOT EXISTs phabricator_audit.audit_comment (
`id` int(10) unsigned NOT NULL AUTO_INCREMENT, `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
`phid` varchar(64) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL, `phid` varchar(64) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL,