From f32971cf81ccca64a99ecf7d14a860fb326425fb Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 29 Apr 2014 11:10:34 -0700 Subject: [PATCH] Hide harbormaster build passes in feed Summary: These stories/notifications aren't too useful, just turn them off at least for now. Test Plan: Will vet this in a sec... Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D8899 --- .../storage/PhabricatorApplicationTransaction.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php index b5194c8e83..c42f367892 100644 --- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php +++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php @@ -451,6 +451,15 @@ abstract class PhabricatorApplicationTransaction switch ($this->getTransactionType()) { case PhabricatorTransactions::TYPE_TOKEN: return true; + case PhabricatorTransactions::TYPE_BUILDABLE: + switch ($this->getNewValue()) { + case HarbormasterBuildable::STATUS_PASSED: + // For now, don't notify on build passes either. These are pretty + // high volume and annoying, with very little present value. We + // might want to turn them back on in the specific case of + // build successes on the current document? + return true; + } } return $this->shouldHide();