Fix some method signatures

Summary: Fix some method signatures so that arguments with default values are at the end of the argument list (see D12418).

Test Plan: Eyeballed the callsites.

Reviewers: epriestley, #blessed_reviewers, hach-que

Reviewed By: epriestley, #blessed_reviewers, hach-que

Subscribers: hach-que, Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12782

src/applications/celerity/CelerityStaticResourceResponse.php

@@ -33,14 +33,16 @@ final class CelerityStaticResourceResponse {
   }
 
   /**
-   * Register a behavior for initialization. NOTE: if $config is empty,
+   * Register a behavior for initialization.
-   * a behavior will execute only once even if it is initialized multiple times.
+   *
-   * If $config is nonempty, the behavior will be invoked once for each config.
+   * NOTE: If `$config` is empty, a behavior will execute only once even if it
+   * is initialized multiple times. If `$config` is nonempty, the behavior will
+   * be invoked once for each configuration.
    */
   public function initBehavior(
     $behavior,
     array $config = array(),
-    $source_name) {
+    $source_name = null) {
 
     $this->requireResource('javelin-behavior-'.$behavior, $source_name);
 

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

@@ -353,7 +353,7 @@ abstract class DrydockBlueprintImplementation {
   public static function writeLog(
     DrydockResource $resource = null,
     DrydockLease $lease = null,
-    $message) {
+    $message = null) {
 
     $log = id(new DrydockLog())
       ->setEpoch(time())

src/applications/people/storage/PhabricatorUserLog.php

@@ -87,8 +87,8 @@ final class PhabricatorUserLog extends PhabricatorUserDAO
 
   public static function initializeNewLog(
     PhabricatorUser $actor = null,
-    $object_phid,
+    $object_phid = null,
-    $action) {
+    $action = null) {
 
     $log = new PhabricatorUserLog();
 

src/applications/phragment/storage/PhragmentFragment.php

@@ -78,9 +78,9 @@ final class PhragmentFragment extends PhragmentDAO
   public static function createFromFile(
     PhabricatorUser $viewer,
     PhabricatorFile $file = null,
-    $path,
+    $path = null,
-    $view_policy,
+    $view_policy = null,
-    $edit_policy) {
+    $edit_policy = null) {
 
     $fragment = id(new PhragmentFragment());
     $fragment->setPath($path);

src/view/layout/AphrontSideNavFilterView.php

@@ -125,12 +125,7 @@ final class AphrontSideNavFilterView extends AphrontView {
       $key, $name, $uri, PHUIListItemView::TYPE_BUTTON);
   }
 
-  private function addThing(
+  private function addThing($key, $name, $uri, $type) {
-    $key,
-    $name,
-    $uri = null,
-    $type) {
-
     $item = id(new PHUIListItemView())
       ->setName($name)
       ->setType($type);